Add reminder on rowcmp

Pietro Vertechi · Pietro Vertechi · commit 077d84924843 · 2019-03-24T13:58:52.000Z
diff --git a/src/groupjoin.jl b/src/groupjoin.jl
@@ -1,3 +1,5 @@
+# Important, for broadcast joins we cannot assume c and d have same number of columns:
+# c could have more columns than d
 @generated function rowcmp(c::StructVector, i, d::StructVector{C, D}, j) where {C, D}
     N = fieldcount(D)
     ex = :(cmp(getfield(fieldarrays(c),$N)[i], getfield(fieldarrays(d),$N)[j]))

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# Important, for broadcast joins we cannot assume c and d have same number of columns:`
	`2`	`+# c could have more columns than d`
`1`	`3`	`@generated function rowcmp(c::StructVector, i, d::StructVector{C, D}, j) where {C, D}`
`2`	`4`	`N = fieldcount(D)`
`3`	`5`	`ex = :(cmp(getfield(fieldarrays(c),$N)[i], getfield(fieldarrays(d),$N)[j]))`