make skipping stdlib tests work (#26700)

* make skipping stdlib tests work

* also allow filtering of test groups in stdlibs

* make ambiguous run first

* Symbol -> String in errorshow

Author: KristofferC

test/choosetests.jl

@@ -124,27 +124,6 @@ function choosetests(choices = [])
         prepend!(tests, STDLIBS)
     end
 
-
-    explicit_pkg     =  "Pkg/pkg"        in tests
-    explicit_pkg3    =  "Pkg3/pkg"       in tests
-    explicit_libgit2 =  "LibGit2/online" in tests
-    new_tests = String[]
-    for test in tests
-        if test in STDLIBS
-            testfile = joinpath(STDLIB_DIR, test, "test", "testgroups")
-            if isfile(testfile)
-                prepend!(new_tests, (test * "/") .* readlines(testfile))
-            else
-                push!(new_tests, test)
-            end
-        end
-    end
-    filter!(x -> (x != "stdlib" && !(x in STDLIBS)) , tests)
-    prepend!(tests, new_tests)
-    explicit_pkg     || filter!(x -> x != "Pkg/pkg",        tests)
-    explicit_pkg3    || filter!(x -> x != "Pkg3/pkg",       tests)
-    explicit_libgit2 || filter!(x -> x != "LibGit2/online", tests)
-
     # do ambiguous first to avoid failing if ambiguities are introduced by other tests
     if "ambiguous" in skip_tests
         filter!(x -> x != "ambiguous", tests)
@@ -183,5 +162,28 @@ function choosetests(choices = [])
 
     filter!(!in(skip_tests), tests)
 
+    explicit_pkg     =  "Pkg/pkg"        in tests
+    explicit_pkg3    =  "Pkg3/pkg"       in tests
+    explicit_libgit2 =  "LibGit2/online" in tests
+    new_tests = String[]
+    for test in tests
+        if test in STDLIBS
+            testfile = joinpath(STDLIB_DIR, test, "test", "testgroups")
+            if isfile(testfile)
+                prepend!(new_tests, (test * "/") .* readlines(testfile))
+            else
+                push!(new_tests, test)
+            end
+        end
+    end
+    filter!(x -> (x != "stdlib" && !(x in STDLIBS)) , tests)
+    append!(tests, new_tests)
+    explicit_pkg     || filter!(x -> x != "Pkg/pkg",        tests)
+    explicit_pkg3    || filter!(x -> x != "Pkg3/pkg",       tests)
+    explicit_libgit2 || filter!(x -> x != "LibGit2/online", tests)
+
+    # Filter out tests from the test groups in the stdlibs
+    filter!(!in(skip_tests), tests)
+
     tests, net_on, exit_on_error, seed
 end

test/errorshow.jl

@@ -322,8 +322,8 @@ end
 @test occursin(r"^@doc \(macro with \d+ method[s]?\)$", repr("text/plain", getfield(Base, Symbol("@doc"))))
 
 method_defs_lineno = @__LINE__() + 1
-Base.Symbol() = throw(ErrorException("1"))
-(::Symbol)() = throw(ErrorException("2"))
+String() = throw(ErrorException("1"))
+(::String)() = throw(ErrorException("2"))
 EightBitType() = throw(ErrorException("3"))
 (::EightBitType)() = throw(ErrorException("4"))
 EightBitTypeT() = throw(ErrorException("5"))
@@ -338,10 +338,10 @@ let err_str,
     sp = Base.source_path()
     sn = basename(sp)
 
-    @test sprint(show, which(Symbol, Tuple{})) ==
-        "Symbol() in $curmod_str at $sp:$(method_defs_lineno + 0)"
-    @test sprint(show, which(:a, Tuple{})) ==
-        "(::Symbol)() in $curmod_str at $sp:$(method_defs_lineno + 1)"
+    @test sprint(show, which(String, Tuple{})) ==
+        "String() in $curmod_str at $sp:$(method_defs_lineno + 0)"
+    @test sprint(show, which("a", Tuple{})) ==
+        "(::String)() in $curmod_str at $sp:$(method_defs_lineno + 1)"
     @test sprint(show, which(EightBitType, Tuple{})) ==
         "$(curmod_prefix)EightBitType() in $curmod_str at $sp:$(method_defs_lineno + 2)"
     @test sprint(show, which(reinterpret(EightBitType, 0x54), Tuple{})) ==
@@ -359,10 +359,10 @@ let err_str,
     @test repr("text/plain", FunctionLike()) == "(::$(curmod_prefix)FunctionLike) (generic function with 1 method)"
     @test repr("text/plain", Core.arraysize) == "arraysize (built-in function)"
 
-    err_str = @except_stackframe Symbol() ErrorException
-    @test err_str == "Symbol() at $sn:$(method_defs_lineno + 0)"
-    err_str = @except_stackframe :a() ErrorException
-    @test err_str == "(::Symbol)() at $sn:$(method_defs_lineno + 1)"
+    err_str = @except_stackframe String() ErrorException
+    @test err_str == "String() at $sn:$(method_defs_lineno + 0)"
+    err_str = @except_stackframe "a"() ErrorException
+    @test err_str == "(::String)() at $sn:$(method_defs_lineno + 1)"
     err_str = @except_stackframe EightBitType() ErrorException
     @test err_str == "$(curmod_prefix)EightBitType() at $sn:$(method_defs_lineno + 2)"
     err_str = @except_stackframe i() ErrorException