make norm handle missings

Author: dkarrasch

stdlib/LinearAlgebra/src/generic.jl

@@ -456,6 +456,7 @@ function generic_normMinusInf(x)
         y === nothing && break
         (v, s) = y
         vnorm = norm(v)
+        ismissing(vnorm) && return missing
         minabs = ifelse(isnan(minabs) | (minabs < vnorm), minabs, vnorm)
     end
     return float(minabs)
@@ -464,11 +465,13 @@ end
 function generic_normInf(x)
     (v, s) = iterate(x)::Tuple
     maxabs = norm(v)
+    ismissing(maxabs) && return missing
     while true
         y = iterate(x, s)
         y === nothing && break
         (v, s) = y
         vnorm = norm(v)
+        ismissing(vnorm) && return missing
         maxabs = ifelse(isnan(maxabs) | (maxabs > vnorm), maxabs, vnorm)
     end
     return float(maxabs)
@@ -477,6 +480,7 @@ end
 function generic_norm1(x)
     (v, s) = iterate(x)::Tuple
     av = float(norm(v))
+    ismissing(av) && return missing
     T = typeof(av)
     sum::promote_type(Float64, T) = av
     while true
@@ -485,6 +489,7 @@ function generic_norm1(x)
         (v, s) = y
         sum += norm(v)
     end
+    ismissing(sum) && return missing
     return convert(T, sum)
 end
 
@@ -495,7 +500,7 @@ norm_sqr(x::Union{T,Complex{T},Rational{T}}) where {T<:Integer} = abs2(float(x))
 
 function generic_norm2(x)
     maxabs = normInf(x)
-    (maxabs == 0 || isinf(maxabs)) && return maxabs
+    (ismissing(maxabs) || maxabs == 0 || isinf(maxabs)) && return maxabs
     (v, s) = iterate(x)::Tuple
     T = typeof(maxabs)
     if isfinite(length(x)*maxabs*maxabs) && maxabs*maxabs != 0 # Scaling not necessary
@@ -506,6 +511,7 @@ function generic_norm2(x)
             (v, s) = y
             sum += norm_sqr(v)
         end
+        ismissing(sum) && return missing
         return convert(T, sqrt(sum))
     else
         sum = abs2(norm(v)/maxabs)
@@ -515,6 +521,7 @@ function generic_norm2(x)
             (v, s) = y
             sum += (norm(v)/maxabs)^2
         end
+        ismissing(sum) && return missing
         return convert(T, maxabs*sqrt(sum))
     end
 end
@@ -525,7 +532,7 @@ function generic_normp(x, p)
     (v, s) = iterate(x)::Tuple
     if p > 1 || p < -1 # might need to rescale to avoid overflow
         maxabs = p > 1 ? normInf(x) : normMinusInf(x)
-        (maxabs == 0 || isinf(maxabs)) && return maxabs
+        (ismissing(maxabs) || maxabs == 0 || isinf(maxabs)) && return maxabs
         T = typeof(maxabs)
     else
         T = typeof(float(norm(v)))
@@ -539,15 +546,18 @@ function generic_normp(x, p)
             (v, s) = y
             sum += norm(v)^spp
         end
+        ismissing(sum) && return missing
         return convert(T, sum^inv(spp))
     else # rescaling
         sum = (norm(v)/maxabs)^spp
+        ismissing(sum) && return missing
         while true
             y = iterate(x, s)
             y === nothing && break
             (v, s) = y
             sum += (norm(v)/maxabs)^spp
         end
+        ismissing(sum) && return missing
         return convert(T, maxabs*sum^inv(spp))
     end
 end

stdlib/LinearAlgebra/test/generic.jl

@@ -448,6 +448,15 @@ end
 
 @testset "missing values" begin
     @test ismissing(norm(missing))
+    x = [5, 6, missing]
+    y = [missing, 5, 6]
+    @test ismissing(dot(x, x))
+    @test ismissing(dot(x, y))
+    @test ismissing(dot(y, x))
+    for p in (-Inf, -1, 0, 1, 2, 3, Inf)
+        @test ismissing(norm(x))
+        @test ismissing(norm(y))
+    end
 end
 
 @testset "peakflops" begin
@@ -512,14 +521,6 @@ end
     end
 end
 
-@testset "dot with missing" begin
-    x = [5, 6, missing]
-    y = [missing, 5, 6]
-    @test ismissing(dot(x, x))
-    @test ismissing(dot(x, y))
-    @test ismissing(dot(y, x))
-end
-
 @testset "condskeel #34512" begin
     A = rand(3, 3)
     @test condskeel(A) ≈ condskeel(A, [8,8,8])