Merge pull request #16551 from JuliaLang/tk/tempfiles

Clean up temporary files from tests

Author: JeffBezanson

test/compile.jl

@@ -127,7 +127,6 @@ finally
 end
 
 # test --compilecache=no command line option
-dir = mktempdir()
 let dir = mktempdir(),
     Time_module = :Time4b3a94a1a081a8cb
 

test/core.jl

@@ -2345,7 +2345,8 @@ end === nothing
 # issue #10221
 module GCbrokentype
 OLD_STDOUT = STDOUT
-file = open(tempname(), "w")
+fname = tempname()
+file = open(fname, "w")
 redirect_stdout(file)
 versioninfo()
 try
@@ -2356,6 +2357,7 @@ end
 gc()
 redirect_stdout(OLD_STDOUT)
 close(file)
+rm(fname)
 end
 
 # issue #10373

test/file.jl

@@ -289,6 +289,7 @@ my_tempdir = tempdir()
 path = tempname()
 # Issue #9053.
 @test ispath(path) == is_windows()
+ispath(path) && rm(path)
 
 (p, f) = mktemp()
 print(f, "Here is some text")

test/parallel_exec.jl

@@ -331,12 +331,13 @@ check_pids_all(S)
 filedata = similar(Atrue)
 read!(fn, filedata)
 @test filedata == sdata(S)
+finalize(S)
 
 # Error for write-only files
 @test_throws ArgumentError SharedArray(fn, Int, sz, mode="w")
 
 # Error for file doesn't exist, but not allowed to create
-@test_throws ArgumentError SharedArray(tempname(), Int, sz, mode="r")
+@test_throws ArgumentError SharedArray(joinpath(tempdir(),randstring()), Int, sz, mode="r")
 
 # Creating a new file
 fn2 = tempname()
@@ -345,6 +346,7 @@ S = SharedArray(fn2, Int, sz, init=D->D[localindexes(D)] = myid())
 filedata2 = similar(Atrue)
 read!(fn2, filedata2)
 @test filedata == filedata2
+finalize(S)
 
 # Appending to a file
 fn3 = tempname()
@@ -356,11 +358,14 @@ filedata = Array(UInt8, len)
 read!(fn3, filedata)
 @test all(filedata[1:4] .== 0x01)
 @test all(filedata[5:end] .== 0x02)
-
-if !is_windows()
-    # these give unlink: operation not permitted (EPERM) on Windows
-    rm(fn); rm(fn2); rm(fn3)
-end
+finalize(S)
+
+# call gc 3 times to avoid unlink: operation not permitted (EPERM) on Windows
+S = nothing
+@everywhere gc()
+@everywhere gc()
+@everywhere gc()
+rm(fn); rm(fn2); rm(fn3)
 
 ### Utility functions
 

test/replcompletions.jl

@@ -636,7 +636,7 @@ if is_windows()
         s = "cd(\"$(file[1:2])"
         c,r = test_complete(s)
         @test r == length(s) - 1:length(s)
-        @test file  in c
+        @test (length(c) > 1 && file in c) || (["$file\""] == c)
     end
     rm(tmp)
 end