Skip to content

Commit b3fc8ac

Browse files
author
Andy Ferris
committed
Fixed broken test, typo, spacing
1 parent 5f0ce4e commit b3fc8ac

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

base/linalg/rowvector.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ convert{T,V<:AbstractVector}(::Type{RowVector{T,V}}, rowvec::RowVector) =
5252
@inline similar(rowvec::RowVector) = RowVector(similar(parent(rowvec)))
5353
@inline similar{T}(rowvec::RowVector, ::Type{T}) = RowVector(similar(parent(rowvec), transpose_type(T)))
5454

55-
# Resizing similar currently looses its RowVector property.
55+
# Resizing similar currently loses its RowVector property.
5656
@inline similar{T,N}(rowvec::RowVector, ::Type{T}, dims::Dims{N}) = similar(parent(rowvec), T, dims)
5757

5858
# Basic methods

test/linalg/conjarray.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
end
1313

1414
@testset "RowVector conjugates" begin
15-
v = [1+im, 1-im]
16-
rv = v'
17-
@test (parent(rv) isa ConjArray)
18-
@test rv' === v
15+
v = [1+im, 1-im]
16+
rv = v'
17+
@test (parent(rv) isa ConjArray)
18+
@test rv' === v
1919

20-
# Currently, view behavior defaults to only RowVectors.
21-
@test isa((v').', Vector)
22-
@test isa((v.')', Vector)
20+
# Currently, view behavior defaults to only RowVectors.
21+
@test isa((v').', Vector)
22+
@test isa((v.')', Vector)
2323
end

test/sparse/sparse.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1641,10 +1641,10 @@ end
16411641
@test At_ldiv_B(ltintmat, sparse(intmat)) At_ldiv_B(ltintmat, intmat)
16421642
end
16431643

1644-
# Test temporary fix for issue #16548 in PR #16979. Brittle. Expect to remove with `\` revisions.
1645-
# This is broken by the introduction of RowVector... see brittle comment above.
1644+
# Test temporary fix for issue #16548 in PR #16979. Somewhat brittle. Expect to remove with `\` revisions.
16461645
@testset "issue #16548" begin
1647-
@test_broken which(\, (SparseMatrixCSC, AbstractVecOrMat)).module == Base.SparseArrays
1646+
ms = methods(\, (SparseMatrixCSC, AbstractVecOrMat)).ms
1647+
@test all(m -> m.module == Base.SparseArrays, ms)
16481648
end
16491649

16501650
@testset "row indexing a SparseMatrixCSC with non-Int integer type" begin

0 commit comments

Comments
 (0)