Skip to content

Some docstrings still have poor formatting #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
malmaud opened this issue Sep 9, 2015 · 7 comments
Closed

Some docstrings still have poor formatting #13039

malmaud opened this issue Sep 9, 2015 · 7 comments

Comments

@malmaud
Copy link
Contributor

malmaud commented Sep 9, 2015

Unless I'm doing something wrong, the following functions still have strange formatting when I view their docs (with ?) from the repl:

  • count_ones
  • count_zeros
  • wait
  • cholfact!
  • println
  • rand
  • randstring
  • randcycle
  • exp
  • sqrt
@malmaud
Copy link
Contributor Author

malmaud commented Sep 9, 2015

More:

  • sinpi
  • sinc
  • cospi
  • cosc
  • append!
  • push!
  • isimmutable
  • map
  • map!
  • ifft
  • fieldoffsets
  • SymTridiagonal
  • lgamma
  • mapreduce

@jakebolewski
Copy link
Member

That is because these are just RST code blocks not Markdown. Until we transition the manual to Markdown the rendering of these docstrings will be raw RST in the terminal. We could write a pretty printer for RST, but I think effort is better spent to complete the transition.

@malmaud
Copy link
Contributor Author

malmaud commented Sep 9, 2015

That's fair, but is .4 really going to be released with the docs for functions like map and push! just printing raw RST?

@jakebolewski
Copy link
Member

Yes, unless someone wants to write a pretty printer. Also, we use RST comments to match the signature so the pretty printer would have to be written specifically for the non-standard RST formatting we are using.

@mbauman
Copy link
Member

mbauman commented Sep 9, 2015

Is there a list of the syntaxes that are barring their transition to Markdown? Is it possible to work on supporting the unsupported? We'll want to have these things anyways:

  • doc-tests (could be fenced codeblocks, e.g., ````jldoctest`)
  • manual cross-links (maybe [link text](_rst_anchor) or some other special way of designating an rst anchor)
  • function and object cross-references :func:foo`` (maybe splice in $(link(foo))?)

Are there other unsupported syntaxes?

@jakebolewski
Copy link
Member

See #12573 and linked issues

@jiahao
Copy link
Member

jiahao commented Sep 9, 2015

Equations and cross-references are my two big concerns. Citations are a distinct third. Scholarly Markdown is the closest attempt I've seen to address these in an extended Markdown format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants