Skip to content

Commit 7887c3e

Browse files
authored
Restrict check_mul_axes to specific Q-matrix-types (#103)
* Restrict `check_mul_axes` to specific Q-matrix-types * Update Project.toml * Update ArrayLayouts.jl
1 parent c20d16d commit 7887c3e

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "ArrayLayouts"
22
uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
33
authors = ["Sheehan Olver <[email protected]>"]
4-
version = "0.8.9"
4+
version = "0.8.10"
55

66
[deps]
77
FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"

src/ArrayLayouts.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ import Base.Broadcast: BroadcastStyle, AbstractArrayStyle, Broadcasted, broadcas
3434
combine_eltypes, DefaultArrayStyle, instantiate, materialize,
3535
materialize!, eltypes
3636

37-
import LinearAlgebra: AbstractTriangular, AbstractQ, checksquare, pinv, fill!, tilebufsize, factorize, qr, lu, cholesky,
37+
import LinearAlgebra: AbstractTriangular, AbstractQ, QRCompactWYQ, QRPackedQ, checksquare, pinv,
38+
fill!, tilebufsize, factorize, qr, lu, cholesky,
3839
norm2, norm1, normInf, normMinusInf, qr, lu, qr!, lu!, AdjOrTrans, HermOrSym, AdjointAbsVec,
3940
TransposeAbsVec, cholcopy, checknonsingular, _apply_ipiv_rows!, ipiv2perm, RealHermSymComplexHerm, chkfullrank
4041

src/mul.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ function check_mul_axes(A, B, C...)
9595
end
9696

9797
# we need to special case AbstractQ as it allows non-compatiple multiplication
98-
function check_mul_axes(A::AbstractQ, B, C...)
98+
function check_mul_axes(A::Union{QRCompactWYQ,QRPackedQ}, B, C...)
9999
axes(A.factors, 1) == axes(B, 1) || axes(A.factors, 2) == axes(B, 1) ||
100100
throw(DimensionMismatch("First axis of B, $(axes(B,1)) must match either axes of A, $(axes(A))"))
101101
check_mul_axes(B, C...)

0 commit comments

Comments
 (0)