Skip to content

Implement AbstractDenseNLPModel #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks
tmigot opened this issue Apr 23, 2024 · 0 comments
Open
6 tasks

Implement AbstractDenseNLPModel #458

tmigot opened this issue Apr 23, 2024 · 0 comments

Comments

@tmigot
Copy link
Member

tmigot commented Apr 23, 2024

This was motivated by the discussion in #376 and discussions with @dpo @abelsiqueira .

TODO:

  • Add an abstract type, abstract type AbstractDenseNLPModel <: AbstractNLPModel end in https://github.com/JuliaSmoothOptimizers/NLPModels.jl/blob/main/src/NLPModels.jl
  • define jac!(), hess!() and jth_hess! only for types that are <: AbstractDenseNLPModel (adapt Add methods for dense Hessian and dense Jacobian #378) -- docstring in src/nlp/api.jl
  • Implement hess_coord/structure, jth_hess_coord/structure and jac_coord/structure using the dense matrices (so that it is compatible with solvers) in a new file dense.jl in the folder src/nlp
  • Add the new API in problems from NLPModelsTest with tests
  • Add a concrete implementation in ManualNLPModels
  • Add a concrete implementation in ADNLPModels

@frapac @sshin23 @amontoison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant