Skip to content

corspearman doesn't deal with NaNs #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yha opened this issue Feb 9, 2021 · 1 comment · Fixed by #659
Closed

corspearman doesn't deal with NaNs #657

yha opened this issue Feb 9, 2021 · 1 comment · Fixed by #659

Comments

@yha
Copy link
Contributor

yha commented Feb 9, 2021 

julia> corspearman([1,2],[3,NaN])
1.0

should be NaN.
Looks like this was fixed in the distant past (#17), but not added to the tests.
@nalimilan nalimilan mentioned this issue Feb 14, 2021
Merged
@nalimilan
Copy link
Member

Good catch. See #659.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of NaN in ranks and rank correlations JuliaStats/StatsBase.jl
2 participants
@nalimilan @yha