skip healthcheck (#168)

* skip healthcheck

* update biome

* biome fixes

Author: jackkav

.github/workflows/test.yaml

@@ -9,6 +9,6 @@ jobs:
       with:
         node-version: 21
     - run: npm ci
-    - uses: biomejs/setup-biome@v1
+    - uses: biomejs/setup-biome@v2
     - run: biome ci .
     - run: npm test

lib/middleware/body-parser.js

@@ -1,5 +1,5 @@
 const Dicer = require("dicer");
-const querystring = require("querystring");
+const querystring = require("node:querystring");
 const contentTypeParser = require("content-type");
 const util = require("../utils");
 

lib/middleware/negotiate-content.js

@@ -8,7 +8,7 @@ module.exports = (req, res, next) => {
 
 	// am I pretty?
 	const spaces = req.headers["x-pretty-print"]
-		? parseInt(req.headers["x-pretty-print"], 10)
+		? Number.parseInt(req.headers["x-pretty-print"], 10)
 		: 2;
 
 	const xmlOpts = {

lib/routes/bins.js

@@ -3,7 +3,7 @@ const express = require("express");
 const mw = require("../middleware");
 const { createClient } = require("redis");
 const routes = require("./bins/");
-const URL = require("url").URL;
+const URL = require("node:url").URL;
 
 module.exports = function bins(dsnStr) {
 	// parse redis dsn

lib/routes/bins/create.js

@@ -1,5 +1,5 @@
 const debug = require("debug")("mockbin");
-const util = require("util");
+const util = require("node:util");
 const uuid = require("uuid");
 const validate = require("har-validator");
 

lib/routes/bins/sample.js

@@ -1,5 +1,5 @@
 const debug = require("debug")("mockbin");
-const util = require("util");
+const util = require("node:util");
 
 module.exports = (client) => (req, res, next) => {
 	client.get(`bin:${req.params.uuid}`, (err, value) => {

lib/routes/bins/update.js

@@ -1,7 +1,7 @@
 const debug = require("debug")("mockbin");
 const e = require("express");
 const validate = require("har-validator");
-const path = require("path");
+const path = require("node:path");
 
 module.exports = (client) => (req, res, next) => {
 	const id = req.params.uuid;

lib/routes/delay.js

@@ -1,5 +1,5 @@
 module.exports = function delay(req, res, next) {
-	let delay = req.params.ms ? parseInt(req.params.ms, 10) : 200;
+	let delay = req.params.ms ? Number.parseInt(req.params.ms, 10) : 200;
 
 	if (delay > 60000) {
 		delay = 60000;

lib/routes/redirect.js

@@ -1,8 +1,8 @@
-const util = require("util");
+const util = require("node:util");
 
 module.exports = function redirect(req, res, next) {
-	let count = req.params.count ? parseInt(req.params.count, 10) : 1;
-	const status = parseInt(req.params.status_code, 10) || 302;
+	let count = req.params.count ? Number.parseInt(req.params.count, 10) : 1;
+	const status = Number.parseInt(req.params.status_code, 10) || 302;
 	const valid = [300, 301, 302, 303, 307, 308];
 
 	if (count > 100) {

lib/routes/stream.js

@@ -5,7 +5,7 @@ module.exports = function stream(req, res, next) {
 	});
 
 	// set default chunks to 10
-	let chunks = req.params.chunks ? parseInt(req.params.chunks, 10) : 10;
+	let chunks = req.params.chunks ? Number.parseInt(req.params.chunks, 10) : 10;
 
 	// max out chunks at 100
 	if (chunks > 100) {

package-lock.json

@@ -43,7 +43,7 @@
 		"clean": "git clean -fdX"
 	},
 	"devDependencies": {
-		"@biomejs/biome": "1.4.1",
+		"@biomejs/biome": "1.6.4",
 		"mocha": "^10.2.0",
 		"should": "^13.2.3"
 	},

package.json

@@ -4,7 +4,7 @@ const debug = require("debug")("mockbin");
 const express = require("express");
 const methodOverride = require("method-override");
 const morgan = require("morgan");
-const path = require("path");
+const path = require("node:path");
 const router = require("../lib");
 
 module.exports = (options, done) => {
@@ -32,7 +32,9 @@ module.exports = (options, done) => {
 
 	app.use(
 		morgan("dev", {
-			skip: (req, res) => options.quiet === "true" && res.statusCode < 400,
+			skip: (req, res) =>
+				req.baseUrl === "/healthcheck" ||
+				(options.quiet === "true" && res.statusCode < 400),
 		}),
 	);
 

src/index.js

@@ -178,7 +178,7 @@ $(() => {
 		});
 
 		// fix type issues
-		response.status = parseInt(response.status, 10);
+		response.status = Number.parseInt(response.status, 10);
 
 		$('input[name="response"]').val(JSON.stringify(response));
 		$("pre code").text(JSON.stringify(response, null, 2));

src/static/bin/create.js

@@ -1,7 +1,7 @@
 const cookieParser = require("cookie-parser");
 const express = require("express");
 const mockbin = require("../../lib");
-const path = require("path");
+const path = require("node:path");
 
 const app = express();
 let server = null;