Move diagnostics server running outside of manager

[czeslavo]

Is there an existing issue for this?

• I have searched the existing issues

Does this enhancement require public documentation?

• I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

To make it possible to not run the diagnostics server as part of the manager, we've added DisableRunningDiagnosticsServer flag to the Config struct. It's needed in KGO so that we can run a manager without the diagnostics server as otherwise it wouldn't be possible to run multiple instances of the manager.

The goal of this issue is to remove this flag and move the logic responsible for running the diagnostics server outside of the manager (from

kubernetes-ingress-controller/internal/manager/run.go

Line 497 in 224424e

go func() {

to

kubernetes-ingress-controller/internal/cmd/rootcmd/run.go

Line 40 in 04f900c

health.NewHealthCheckServer(

).

Proposed Solution

Move code that runs the diagnostics server out of manager.Manager. It can be done similarly to the health check server that's run in

kubernetes-ingress-controller/internal/cmd/rootcmd/run.go

Line 40 in 04f900c

health.NewHealthCheckServer(

.

Additional information

No response

Acceptance Criteria

• DisableRunningDiagnosticsServer in Config struct is removed
• By default, manager.Manager is run without a diagnostics server