Skip to content

Modlauncher can't detect interfaces of transformer parents #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Su5eD opened this issue Feb 27, 2022 · 2 comments
Closed

Modlauncher can't detect interfaces of transformer parents #97

Su5eD opened this issue Feb 27, 2022 · 2 comments
Labels

Comments

@Su5eD
Copy link
Member

Su5eD commented Feb 27, 2022

Suppose you have a base ITransformer class with a subclass for each type:

public abstract class BaseTransformer<T> implements ITransformer<T>
├─ public class ClassTransformer extends BaseTransformer<ClassNode>
├─ public class MethodTransformer extends BaseTransformer<MethodNode>
└─ public class FieldTransformer extends BaseTransformer<FieldNode>

Modlauncher expects the interface to be implemented in the transformer class itself.
Therefore running this structure will result in an exception.

@cpw
Copy link
Member

cpw commented Jun 14, 2023

arguably, this is a trivial fix in the code: implement on the class itself, rather than the parent. It's a bit untidier but would result in functional code.

@Su5eD
Copy link
Member Author

Su5eD commented Oct 24, 2023

Fixed by #102

@Su5eD Su5eD closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants