From 5239aab98b16c19f089503c803c77284a448766a Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Wed, 7 May 2025 23:22:31 +0000 Subject: [PATCH 01/12] Update nf-dbghelp-symfindexecutableimage.md For some reason this function passes MAX_PATH + 1 as the size of ImageFilePath to GetFullPathName, which dutifully clears MAX_PATH + 1 characters and writes past the end of a MAX_PATH sized buffer --- .../content/dbghelp/nf-dbghelp-symfindexecutableimage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimage.md b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimage.md index 326c5ec9e48e..837e4b405afc 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimage.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimage.md @@ -67,7 +67,7 @@ The name of the executable file. You can use a partial path. ### -param ImageFilePath [out] -The fully qualified path of the executable file. This buffer must be at least MAX_PATH characters. +The fully qualified path of the executable file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in] From cd4bee1afea81be72f1f20b2b28f418da54f9a50 Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Wed, 7 May 2025 23:26:23 +0000 Subject: [PATCH 02/12] Update nf-dbghelp-findexecutableimageexw.md --- .../content/dbghelp/nf-dbghelp-findexecutableimageexw.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageexw.md b/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageexw.md index 2ffc99a0ace8..5fd66cc63649 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageexw.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageexw.md @@ -67,7 +67,7 @@ The path where symbol files are located. This string can contain multiple paths ### -param ImageFilePath [out] -A pointer to a buffer that receives the full path of the executable file. +A pointer to a buffer that receives the full path of the executable file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in, optional] From 536dd2166875686663cbac901a821588f7e6a3a8 Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Wed, 7 May 2025 23:28:22 +0000 Subject: [PATCH 03/12] Update nf-dbghelp-findexecutableimageex.md --- sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageex.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageex.md b/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageex.md index 4136aaf5bed0..4eaab2189b79 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageex.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimageex.md @@ -67,7 +67,7 @@ The path where symbol files are located. This string can contain multiple paths ### -param ImageFilePath [out] -A pointer to a buffer that receives the full path of the executable file. +A pointer to a buffer that receives the full path of the executable file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in, optional] From b4dd92b400e2e61e980a339f49cc9b9f414567f7 Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Wed, 7 May 2025 23:29:32 +0000 Subject: [PATCH 04/12] Update nf-dbghelp-findexecutableimage.md --- sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimage.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimage.md b/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimage.md index f92bd13e683d..15fbb13e98ee 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimage.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-findexecutableimage.md @@ -68,7 +68,7 @@ The path where symbol files are located. This can be multiple paths separated by ### -param ImageFilePath [out] -A pointer to a buffer that receives the full path of the executable file. +A pointer to a buffer that receives the full path of the executable file. This buffer must be at least MAX_PATH+1 characters. ## -returns @@ -94,4 +94,4 @@ All DbgHelp functions, such as this one, are single threaded. Therefore, calls f -SymGetSearchPath \ No newline at end of file +SymGetSearchPath From c9d145cf0168ced4fa1b3dfae468a94de2fea2ff Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Wed, 7 May 2025 23:30:01 +0000 Subject: [PATCH 05/12] Update nf-dbghelp-symfindexecutableimagew.md --- .../content/dbghelp/nf-dbghelp-symfindexecutableimagew.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimagew.md b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimagew.md index c03f09863aa7..e9e601ca3382 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimagew.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindexecutableimagew.md @@ -67,7 +67,7 @@ The name of the executable file. You can use a partial path. ### -param ImageFilePath [out] -The fully qualified path of the executable file. This buffer must be at least MAX_PATH characters. +The fully qualified path of the executable file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in] From e013b26f2ff82264d66d6c61f1e7d809d730dea8 Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Mon, 19 May 2025 18:54:15 +0000 Subject: [PATCH 06/12] Update nf-dbghelp-symfindfileinpath.md --- sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpath.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpath.md b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpath.md index 3f1eeadc91f4..00cf2c68cd48 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpath.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpath.md @@ -129,7 +129,7 @@ The id parameter is a pointer to a GUID. ### -param FoundFile [out] -A pointer to a buffer that receives the fully qualified path to the symbol file. This buffer must be at least MAX_PATH characters. +A pointer to a buffer that receives the fully qualified path to the symbol file. This buffer must be at least MAX_PATH+1 characters. ### -param callback [in, optional] From d80ab19264399e587f92f0b63ac91471ce38b06b Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Mon, 19 May 2025 18:54:44 +0000 Subject: [PATCH 07/12] Update nf-dbghelp-symfindfileinpathw.md --- sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpathw.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpathw.md b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpathw.md index fbb0c8de3972..c55914d2785a 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpathw.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-symfindfileinpathw.md @@ -129,7 +129,7 @@ The id parameter is a pointer to a GUID. ### -param FoundFile [out] -A pointer to a buffer that receives the fully qualified path to the symbol file. This buffer must be at least MAX_PATH characters. +A pointer to a buffer that receives the fully qualified path to the symbol file. This buffer must be at least MAX_PATH+1 characters. ### -param callback [in, optional] From b3406b9da5e421013db7587298c1c2b91b02bd9f Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Mon, 19 May 2025 18:55:39 +0000 Subject: [PATCH 08/12] Update nf-dbghelp-symfinddebuginfofile.md --- sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofile.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofile.md b/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofile.md index 875cdd18d4ad..8e016e52f481 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofile.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofile.md @@ -67,7 +67,7 @@ The name of the .dbg file. You can use a partial path. ### -param DebugFilePath [out] -The fully qualified path of the .dbg file. This buffer must be at least MAX_PATH characters. +The fully qualified path of the .dbg file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in, optional] From 42c3abbddffc73dc0b83dbdfffa5a1c6860c220f Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Mon, 19 May 2025 18:55:57 +0000 Subject: [PATCH 09/12] Update nf-dbghelp-symfinddebuginfofilew.md --- sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofilew.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofilew.md b/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofilew.md index 21c22b4c2b0b..344db2310172 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofilew.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-symfinddebuginfofilew.md @@ -67,7 +67,7 @@ The name of the .dbg file. You can use a partial path. ### -param DebugFilePath [out] -The fully qualified path of the .dbg file. This buffer must be at least MAX_PATH characters. +The fully qualified path of the .dbg file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in, optional] From dc7150df5322afd8f894ffb95b3143f0a6a737e4 Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Mon, 19 May 2025 18:57:23 +0000 Subject: [PATCH 10/12] Update nf-dbghelp-finddebuginfofile.md --- sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofile.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofile.md b/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofile.md index ec903f89be65..1359585f428c 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofile.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofile.md @@ -69,7 +69,7 @@ The path where symbol files are located. This can be multiple paths separated by ### -param DebugFilePath [out] -A pointer to a buffer that receives the full path of the .dbg file. +A pointer to a buffer that receives the full path of the .dbg file. This buffer must be at least MAX_PATH+1 characters. ## -returns @@ -95,4 +95,4 @@ All DbgHelp functions, such as this one, are single threaded. Therefore, calls f -SymGetSearchPath \ No newline at end of file +SymGetSearchPath From 0107411eb7e8db113486b98fc3b0a629de51c533 Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Mon, 19 May 2025 18:57:53 +0000 Subject: [PATCH 11/12] Update nf-dbghelp-finddebuginfofileex.md --- sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileex.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileex.md b/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileex.md index 503d09666ae3..3ebd6212a985 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileex.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileex.md @@ -68,7 +68,7 @@ The path where symbol files are located. This can be multiple paths separated by ### -param DebugFilePath [out] -A pointer to a buffer that receives the full path of the .dbg file. +A pointer to a buffer that receives the full path of the .dbg file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in, optional] From a942eacdc55e4d6cc944cb7311d64c512c396c1b Mon Sep 17 00:00:00 2001 From: adeyblue <57239042+adeyblue@users.noreply.github.com> Date: Mon, 19 May 2025 18:58:25 +0000 Subject: [PATCH 12/12] Update nf-dbghelp-finddebuginfofileexw.md --- sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileexw.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileexw.md b/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileexw.md index 85ac9cfec7a1..a6b0bf593406 100644 --- a/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileexw.md +++ b/sdk-api-src/content/dbghelp/nf-dbghelp-finddebuginfofileexw.md @@ -68,7 +68,7 @@ The path where symbol files are located. This can be multiple paths separated by ### -param DebugFilePath [out] -A pointer to a buffer that receives the full path of the .dbg file. +A pointer to a buffer that receives the full path of the .dbg file. This buffer must be at least MAX_PATH+1 characters. ### -param Callback [in, optional]