Skip to content

Add subtick ability to keyboard (Similar to mouse paths) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
ScribbleTAS opened this issue May 7, 2023 · 0 comments · Fixed by #203
Closed
2 tasks done

Add subtick ability to keyboard (Similar to mouse paths) #164

ScribbleTAS opened this issue May 7, 2023 · 0 comments · Fixed by #203
Assignees
Labels
TASFile Issue relates to the playback file used to store inputs
Milestone

Comments

@ScribbleTAS
Copy link
Member

ScribbleTAS commented May 7, 2023

I was made aware that the keyaboard can perform subtick inputs as well, similar to the mouse.

This is only really useful in guiscreens when using the keyboard to switch hotbar positions.

This also fixes the issue of having to hold certain keys for an input to be registered in low tickrates for example.

  • Increase tasfile version to 2 Make TASFile versions strings.
  • Add unit tests to Virtual Input

New syntax

After thinking about this for a while, I should probably introduce a new syntax for proper subtick handling

Current

55|Keyboard:W,LCONTROL;w|Mouse:;[MOUSEMOVED,0,887,626]->[RC,0,1580,658]->[MOUSEMOVED,0,1580,658]|Camera:17.85;-202.74799~&

Subticks are stored in square brackets. ([MOUSEMOVED,0,887,626]->[RC,0,1580,658] etc...). This looks just very messy

Proposal

55|Keyboard:W,LCONTROL;w|Mouse:;0,887,626|Camera:17.85;-202.74799
	1|Keyboard:|Mouse:RC;0,1580,658|Camera:17.85;-202.74799
	2|Keyboard:|Mouse:;0,1580,658|Camera:17.85;-202.74799

The non indented lines are for ticks, while the indented lines are for subticks.

This way, we can support Mouse and Keyboard subticks, as well as Camera subticks while we are at it.
This also gets rid of the square bracket syntax.
We can also use the existing comparing system for ticks to also check for subticks and maybe add monitoring and control bytes for subtick commands.
And this system is upgradable, the old syntax can be converted into the new one.

@ScribbleTAS ScribbleTAS added Bug Core Issue relates to core concepts labels May 7, 2023
@ScribbleTAS ScribbleTAS added this to the Beta1 milestone May 7, 2023
@ScribbleTAS ScribbleTAS moved this to Todo in TASmod May 20, 2023
@ScribbleTAS ScribbleTAS self-assigned this May 26, 2023
@ScribbleTAS ScribbleTAS mentioned this issue Aug 9, 2023
2 tasks
@ScribbleTAS ScribbleTAS added TASFile Issue relates to the playback file used to store inputs and removed Core Issue relates to core concepts labels Sep 3, 2023
@ScribbleTAS ScribbleTAS moved this from Todo to In Progress in TASmod Jan 13, 2024
@ScribbleTAS ScribbleTAS linked a pull request Feb 8, 2024 that will close this issue
5 tasks
@ScribbleTAS ScribbleTAS removed a link to a pull request Feb 8, 2024
5 tasks
@ScribbleTAS ScribbleTAS mentioned this issue Feb 8, 2024
5 tasks
@ScribbleTAS ScribbleTAS linked a pull request Apr 17, 2024 that will close this issue
8 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in TASmod Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TASFile Issue relates to the playback file used to store inputs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant