Skip to content

Commit 5b73d50

Browse files
committed
Rename "Placemarks" in "Places"
1 parent 4acdde3 commit 5b73d50

7 files changed

+69
-69
lines changed

Package.resolved

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"repositoryURL": "https://github.com/MonkiProjects/monki-projects-model-swift",
77
"state": {
88
"branch": null,
9-
"revision": "e900b58d719939fefcd09172b432d6f0c2fe2b43",
10-
"version": "0.3.4"
9+
"revision": "b6557a9e8d4bf6ed6dadc239759d567985a75370",
10+
"version": "0.4.0"
1111
}
1212
}
1313
]

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ let package = Package(
1919
.package(
2020
name: "monki-projects-model",
2121
url: "https://github.com/MonkiProjects/monki-projects-model-swift",
22-
.upToNextMajor(from: "0.3.4")
22+
.upToNextMajor(from: "0.4.0")
2323
),
2424
],
2525
targets: [

Sources/MonkiProjectsAPIClient/Helpers/PlacemarkState+QueryItems.swift renamed to Sources/MonkiProjectsAPIClient/Helpers/PlaceState+QueryItems.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//
2-
// PlacemarkState+QueryItems.swift
2+
// PlaceState+QueryItems.swift
33
// MonkiProjectsAPIClient
44
//
55
// Created by Rémi Bardon on 22/05/2021.
@@ -10,7 +10,7 @@ import Foundation
1010
import Networking
1111
import MonkiMapModel
1212

13-
extension Placemark.State: QueryParam {
13+
extension Place.State: QueryParam {
1414

1515
public var queryItems: [URLQueryItem] {
1616
return [.init(name: "state", value: self.rawValue)]

Sources/MonkiProjectsAPIClient/MPAPIPlacemarkRepository.swift renamed to Sources/MonkiProjectsAPIClient/MPAPIPlaceRepository.swift

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//
2-
// MPAPIPlacemarkRepository.swift
2+
// MPAPIPlaceRepository.swift
33
// MonkiProjectsAPIClient
44
//
55
// Created by Rémi Bardon on 02/05/2021.
@@ -12,7 +12,7 @@ import Combine
1212
import MonkiProjectsModel
1313
import MonkiMapModel
1414

15-
public final class MPAPIPlacemarkRepository: WebAPI, WebPlacemarksRepository {
15+
public final class MPAPIPlaceRepository: WebAPI, WebPlacesRepository {
1616

1717
/// # Notes
1818
///
@@ -29,36 +29,36 @@ public final class MPAPIPlacemarkRepository: WebAPI, WebPlacemarksRepository {
2929

3030
// MARK: - Combine Publishers
3131

32-
public func listPlacemarks(
33-
state: Placemark.State? = nil,
32+
public func listPlaces(
33+
state: Place.State? = nil,
3434
page: PageRequest? = nil
35-
) -> AnyPublisher<Page<Placemark.Public>, Error> {
36-
return self.authenticatedRequest(endpoints.listPlacemarks(state: state, page: page))
35+
) -> AnyPublisher<Page<Place.Public>, Error> {
36+
return self.authenticatedRequest(endpoints.listPlaces(state: state, page: page))
3737
}
3838

3939
// MARK: - Swift async/await
4040

4141
@available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *)
42-
public func listPlacemarks(
43-
state: Placemark.State? = nil,
42+
public func listPlaces(
43+
state: Place.State? = nil,
4444
page: PageRequest? = nil
45-
) async throws -> Page<Placemark.Public> {
46-
return try await self.authenticatedRequest(endpoints.listPlacemarks(state: state, page: page))
45+
) async throws -> Page<Place.Public> {
46+
return try await self.authenticatedRequest(endpoints.listPlaces(state: state, page: page))
4747
}
4848

4949
}
5050

51-
extension MPAPIPlacemarkRepository {
51+
extension MPAPIPlaceRepository {
5252

5353
internal struct Endpoints: APIEndpoints {
5454

5555
let server: APIServer
5656

57-
func listPlacemarks(
58-
state: Placemark.State? = nil,
57+
func listPlaces(
58+
state: Place.State? = nil,
5959
page: PageRequest? = nil
6060
) -> Endpoint {
61-
return self.get("/placemarks/v1", queryItems: state.queryItems + page.queryItems)
61+
return self.get("/places/v1", queryItems: state.queryItems + page.queryItems)
6262
}
6363

6464
}

Sources/MonkiProjectsAPIClient/MonkiProjectsAPIs.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ public final class MonkiProjectsAPIs: ObservableObject {
5555
/// Monki Projects' Auth API
5656
public var authAPI: WebAuthRepository
5757

58-
/// Monki Projects' Placemarks API
59-
public var placemarksAPI: WebPlacemarksRepository
58+
/// Monki Projects' Places API
59+
public var placesAPI: WebPlacesRepository
6060

6161
// MARK: - Lifecycle
6262

@@ -68,7 +68,7 @@ public final class MonkiProjectsAPIs: ObservableObject {
6868
self.session = WebAPISession(server: server.wrappedValue, urlSession: urlSession, auth: auth)
6969
self.usersAPI = MPAPIUserRepository(session: self.session)
7070
self.authAPI = MPAPIAuthRepository(session: self.session)
71-
self.placemarksAPI = MPAPIPlacemarkRepository(session: self.session)
71+
self.placesAPI = MPAPIPlaceRepository(session: self.session)
7272
}
7373

7474
// TODO: Cancel ongoing requests in APIs?

Sources/MonkiProjectsAPIClient/Protocols/WebPlacemarksRepository.swift

Lines changed: 0 additions & 47 deletions
This file was deleted.
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
//
2+
// WebPlacesRepository.swift
3+
// MonkiProjectsAPIClient
4+
//
5+
// Created by Rémi Bardon on 01/06/2021.
6+
// Copyright © 2021 Monki Projects. All rights reserved.
7+
//
8+
9+
import Foundation
10+
import Combine
11+
import Networking
12+
import MonkiProjectsModel
13+
import MonkiMapModel
14+
15+
public protocol WebPlacesRepository: AnyObject, WebAPI {
16+
17+
// MARK: - Combine Publishers
18+
19+
func listPlaces(
20+
state: Place.State?,
21+
page: PageRequest?
22+
) -> AnyPublisher<Page<Place.Public>, Error>
23+
24+
// MARK: - Swift async/await
25+
26+
@available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *)
27+
func listPlaces(
28+
state: Place.State?,
29+
page: PageRequest?
30+
) async throws -> Page<Place.Public>
31+
32+
}
33+
34+
// MARK: - Functions with default parameters
35+
36+
extension WebPlacesRepository {
37+
38+
public func listPlaces() -> AnyPublisher<Page<Place.Public>, Error> {
39+
return self.listPlaces(state: nil, page: nil)
40+
}
41+
42+
@available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *)
43+
public func listPlaces() async throws -> Page<Place.Public> {
44+
return try await self.listPlaces(state: nil, page: nil)
45+
}
46+
47+
}

0 commit comments

Comments
 (0)