Fix a number of bugs/warnings unearthed by clang. Move to Tcl 8.6.

BUGZID:

Author: lehenbauer

README.FreeBSD

@@ -3,5 +3,5 @@
 #
 
 autoconf
-./configure --with-tcl=/usr/local/lib/tcl8.5  --mandir=/usr/local/man --enable-symbols
+./configure --with-tcl=/usr/local/lib/tcl8.6  --mandir=/usr/local/man --enable-symbols
 

generic/bson.c

@@ -565,11 +565,10 @@ mongotcl_appendBsonFromObject(Tcl_Interp *interp, bson *bs, bson_type bsonType,
 		case BSON_BINDATA: {
 			unsigned char *binary;
 			int binaryLength;
-			int binaryType;
 
 			binary = Tcl_GetByteArrayFromObj (valueObj, &binaryLength);
 
-			if (bson_append_binary (bs, key, binaryType, (char *)binary, binaryLength) != BSON_OK) {
+			if (bson_append_binary (bs, key, bsonBinarySubtype, (char *)binary, binaryLength) != BSON_OK) {
 				return mongotcl_setBsonError (interp, bs);
 			}
 			break;

generic/cursor.c

@@ -155,7 +155,7 @@ mongotcl_tcllist_to_cursor_fields (Tcl_Interp *interp, Tcl_Obj *fieldList, mongo
 		return TCL_ERROR;
 	}
 
-	if (i & 1) {
+	if (listObjc & 1) {
 		Tcl_SetObjResult (interp, Tcl_NewStringObj ("field list must have even number of elements", -1));
 		return TCL_ERROR;
 	}
@@ -318,7 +318,7 @@ mongotcl_cursorObjectObjCmd(ClientData cData, Tcl_Interp *interp, int objc, Tcl_
 
 		case OPT_CURSOR_SET_OPTIONS: {
 			int listObjc;
-			int cursorFlags;
+			int cursorFlags = 0;
 			int i;
 			Tcl_Obj **listObjv;
 

generic/mongotcl.c

@@ -476,7 +476,7 @@ mongotcl_mongoObjectObjCmd(ClientData cData, Tcl_Interp *interp, int objc, Tcl_O
 				}
 			}
 
-			if (mongo_insert_batch (md->conn, Tcl_GetString(objv[2]), bsonList, listObjc, md->write_concern, flags) != MONGO_OK) {
+			if (mongo_insert_batch (md->conn, Tcl_GetString(objv[2]), (const bson **)bsonList, listObjc, md->write_concern, flags) != MONGO_OK) {
 				return mongotcl_setMongoError (interp, md->conn);
 			}
 
@@ -653,29 +653,29 @@ mongotcl_mongoObjectObjCmd(ClientData cData, Tcl_Interp *interp, int objc, Tcl_O
 		}
 
 		case OPT_GET_LAST_ERROR: {
-			bson *out;
+			bson out;
 
 			if (objc != 3) {
 				Tcl_WrongNumArgs (interp, 2, objv, "db");
 				return TCL_ERROR;
 			}
 
-			if (mongo_cmd_get_last_error (md->conn, Tcl_GetString(objv[2]), out) != MONGO_OK) {
+			if (mongo_cmd_get_last_error (md->conn, Tcl_GetString(objv[2]), &out) != MONGO_OK) {
 				return mongotcl_setMongoError (interp, md->conn);
 			}
 
 			break;
 		}
 
 		case OPT_GET_PREV_ERROR: {
-			bson *out;
+			bson out;
 
 			if (objc != 3) {
 				Tcl_WrongNumArgs (interp, 2, objv, "db");
 				return TCL_ERROR;
 			}
 
-			if (mongo_cmd_get_prev_error (md->conn, Tcl_GetString(objv[2]), out) != MONGO_OK) {
+			if (mongo_cmd_get_prev_error (md->conn, Tcl_GetString(objv[2]), &out) != MONGO_OK) {
 				return mongotcl_setMongoError (interp, md->conn);
 			}
 
@@ -941,14 +941,14 @@ mongotcl_mongoObjectObjCmd(ClientData cData, Tcl_Interp *interp, int objc, Tcl_O
 		}
 
 		case OPT_CMD_DROP_COLLECTION: {
-			bson *out;
+			bson out;
 
 			if (objc != 4) {
 				Tcl_WrongNumArgs (interp, 2, objv, "db collect");
 				return TCL_ERROR;
 			}
 
-			if (mongo_cmd_drop_collection (md->conn, Tcl_GetString(objv[2]), Tcl_GetString(objv[3]), out) != MONGO_OK) {
+			if (mongo_cmd_drop_collection (md->conn, Tcl_GetString(objv[2]), Tcl_GetString(objv[3]), &out) != MONGO_OK) {
 				return mongotcl_setMongoError (interp, md->conn);
 			}
 			break;