Open pull requests on Azure DevOps

[hekatx]

Loving neogit, coming from fugitive it's a whole new world. I also used lazygit on the side just because I can press a couple keys and the PR form is open on my browser and been missing that. I know neogit suggests just adding the service to git_services but Azure is fucking weird and I had to do some hacking on the actions.branch.open_pull_request function because what neogit parsed from the remote url doesn't work directly. Here's the thing working:

Now I don't know how to make a PR for this because it implied some changes at open_pull_request. Code at /popups/branch/actions.lua ended up like this:

function M.open_pull_request()
  local template
  local template_type
  local url = git.remote.get_url(git.branch.upstream_remote())[1]

  for s, v in pairs(config.values.git_services) do
    if url:match(util.pattern_escape(s)) then
      template_type = s
      template = v
      break
    end
  end

  if template then
    if vim.ui.open then
      local format_values = git.remote.parse(url)
      format_values["branch_name"] = git.branch.current()

      -- azure is weird
      if template_type == "azure.com" then
        local correctedOwner = string.gsub(format_values["path"], "v3/", "")
        format_values["path"] = correctedOwner
        format_values["owner"] = correctedOwner

        local remote_branches = util.map(git.refs.list_remote_branches("origin"), function(branch)
          branch = string.gsub(branch, "origin/", "")
          return branch
        end)
        local target = FuzzyFinderBuffer.new(util.merge(remote_branches)):open_async {
          prompt_prefix = "Choose target remote branch",
        }
        format_values["target"] = target
      end

      vim.ui.open(util.format(template, format_values))
    else
      notification.warn("Requires Neovim 0.10")
    end
  else
    notification.warn("Pull request URL template not found for this branch's upstream")
  end
end

and git_services:

git_services = {
  ["github.com"] = "https://github.com/${owner}/${repository}/compare/${branch_name}?expand=1",
  ["bitbucket.org"] = "https://bitbucket.org/${owner}/${repository}/pull-requests/new?source=${branch_name}&t=1",
  ["gitlab.com"] = "https://gitlab.com/${owner}/${repository}/merge_requests/new?merge_request[source_branch]=${branch_name}",
  ["azure.com"] = "https://dev.azure.com/${owner}/_git/${repository}/pullrequestcreate?sourceRef=${branch_name}&targetRef=${target}",
}

[CKolkey]

I think azure is big enough that we can ship something like this. Wanna make a PR and add some tests where it makes sense?

And very glad you're enjoying the tool :)