Colors

[XeroOl]

With multiple color schemes, it seems like Neogit chooses terrible highlights to show the diffs.
Here's neogit with the Nord color scheme. Notice how you can't see what the text was changed to.

The DiffAdd group looks like it would be readable, but Neogit instead makes its own version:

Something similar happens when I use the gruvbox color scheme:


In both these colorschemes, and some of my other ones, the DiffAdd added code is unreadable because the foreground and background are too similar to eachother.

Does anyone else seem to have issues with unreadable diffs, when the colorscheme seems to define reasonable colors? I'm trying to figure out how to work around this but Neogit doesn't have any config to override its weird behavior as far as I can tell.

[CKolkey]

Any highlight group that you define (NeogitDiffAdd for example) won't be overloaded by the plugin, so if you want to change something for your setup you don't need an API - just set it like any other highlight group.

That said, this is a surprisingly hard thing to get right, and what I arrived to was just to document the groups and leave it to theme authors to fix. It's not the best solution, but it's the best I came up with. If you have a better idea of how to do it, I'm all ears.