Skip to content

Certificate deletion returns error if it's still being used #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tbaile opened this issue Apr 7, 2025 · 2 comments
Open

Certificate deletion returns error if it's still being used #1156

Tbaile opened this issue Apr 7, 2025 · 2 comments
Assignees
@francio87
Labels
testing Packages are available from testing repositories
Milestone
NethSecurity 8.6

Comments

@Tbaile
Copy link
Collaborator

Tbaile commented Apr 7, 2025

Steps to reproduce

  • Create a certificate for a domain
  • Create a reverse proxy entry with the certificate added earlier
  • Try to delete the certificate

Expected behavior

  • UI shouldn't allow you to try and delete a currently used certificate

Actual behavior

  • UI allows the deletion of said certificate, then backend locks you for doing so (preventing configuration break)

Components

  • ns-ui 1.22.0
@Tbaile Tbaile added this to the NethSecurity 8.6 milestone Apr 7, 2025
@github-project-automation github-project-automation bot moved this to ToDo 🕐 in NethSecurity Apr 7, 2025
@gsanchietti gsanchietti self-assigned this Apr 14, 2025
@gsanchietti
Copy link
Member

This is the current error:

Image

Proposed fix: disable the "Delete" button on the modal and display a warning about used certificate.
Alternative solution: disable the "delete" button from the three-dots menu

@gsanchietti gsanchietti mentioned this issue Apr 15, 2025
Merged
gsanchietti added a commit to NethServer/nethsecurity-ui that referenced this issue Apr 15, 2025
@gsanchietti
fix(certificates): prevent deletion of used certs (#529)
a6793ae 
NethServer/nethsecurity#1156
@Tbaile Tbaile moved this from ToDo 🕐 to In Progress 🛠 in NethSecurity Apr 15, 2025
@gsanchietti
Copy link
Member

Testing image: https://github.com/NethServer/nethsecurity/actions/runs/14492103479/artifacts/2955696996

Test case

  • Check the issue is not reproducible: the delete button has been removed

@gsanchietti gsanchietti added the testing Packages are available from testing repositories label Apr 16, 2025
@gsanchietti gsanchietti assigned Tbaile and unassigned gsanchietti Apr 16, 2025
@nethbot nethbot moved this from In Progress 🛠 to Testing in NethSecurity Apr 16, 2025
@Tbaile Tbaile assigned francio87 and unassigned Tbaile Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francio87 francio87

Labels
testing Packages are available from testing repositories
Projects
NethSecurity
Status: Testing
Milestone
NethSecurity 8.6
Development

No branches or pull requests
3 participants
@gsanchietti @Tbaile @francio87