Skip to content

go-neb is unmaintained, look for an alternative #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfly opened this issue Jan 31, 2025 · 10 comments
Open

go-neb is unmaintained, look for an alternative #549

jfly opened this issue Jan 31, 2025 · 10 comments
Labels
security This issue has potential securtiy implications

Comments

@jfly
Copy link
Contributor

jfly commented Jan 31, 2025

We use go-neb to forward prometheus alerts to matrix:

receiver = "go-neb";

The go-neb github repo was archived on Jun 28, 2023. The README says "matrix-hookshot is the spiritual successor to Go-NEB".

Have we investigated replacing go-neb with matrix-hookshot?

@Erethon
Copy link
Contributor

Erethon commented Jan 31, 2025

There's NixOS/nixpkgs#342663 that "tracks" this in nixpkgs. As mentioned here there's https://github.com/jaywink/matrix-alertmanager that's meant to be used specifically for having alertmanager alerts in Matrix. Since we're only using go-neb for alerts currently, I think matrix-alertmanager is better suited to this instead of Hookshot.

I'm personally using matrix-alertmanager in my infra and recently started maintaining the package in nixpkgs. I plan to write a NixOS module for it once I find some free time.

@Erethon
Copy link
Contributor

Erethon commented Feb 2, 2025

I'm personally using matrix-alertmanager in my infra and recently started maintaining the package in nixpkgs. I plan to write a NixOS module for it once I find some free time.

Opened NixOS/nixpkgs#378966 as a draft, will iterate on it in the coming days.

@jfly
Copy link
Contributor Author

jfly commented Mar 7, 2025

@Erethon, congrats on landing NixOS/nixpkgs#378966! Do you want to take the next step and switch our infra to use it?

@Erethon
Copy link
Contributor

Erethon commented Mar 8, 2025

@Erethon, congrats on landing NixOS/nixpkgs#378966!

Thanks for the thorough review and for helping push it trough the finish line! ❤️

Do you want to take the next step and switch our infra to use it?

Sure! I wont be able to start working on this until after the 12th of March, but I'll have a PR ready towards the end of the week.

@jfly
Copy link
Contributor Author

jfly commented Mar 8, 2025

Thanks! No rush at all.

@jfly
Copy link
Contributor Author

jfly commented Mar 29, 2025

@Erethon, no pressure at all: is this still on your list of things to do?

@Erethon
Copy link
Contributor

Erethon commented Mar 30, 2025

@Erethon, no pressure at all: is this still on your list of things to do?

Yes, I still want to get this done, unfortunately life got in the way. Hopefully I'll have a bit more time this week and will get to it.

@Mic92
Copy link
Member

Mic92 commented Apr 7, 2025

I am happy user of @pinpox's matrixhook: https://github.com/Mic92/dotfiles/blob/6a639e9594fada3fd709ce588bb01eccba7950fd/machines/eva/modules/prometheus/matrix-alertmanager.nix#L4
It's limited to prometheus only, but this seems to be what we need.

@mweinelt mweinelt added the security This issue has potential securtiy implications label May 15, 2025
@mweinelt
Copy link
Member

Flagging as security relevant due to jaywink/matrix-alertmanager#48.

@Erethon
Copy link
Contributor

Erethon commented May 15, 2025

Flagging as security relevant due to jaywink/matrix-alertmanager#48.

I would say it's security relevant because go-neb is unmaintained and not getting updates since 2022 (officiall deprecation notice came in 2023). Matrix-alertmanager is one option we have to migrate to so that we can drop go-neb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security This issue has potential securtiy implications
Projects
Status: Worked Around
Status: Todo
Development

No branches or pull requests

4 participants