Skip to content

[Bug]: PlayerNotificationTargetIncludeAliases Not up to date #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
Luuckyy opened this issue Feb 24, 2025 · 0 comments
Open
1 task done

[Bug]: PlayerNotificationTargetIncludeAliases Not up to date #42

Luuckyy opened this issue Feb 24, 2025 · 0 comments
Labels

Comments

@Luuckyy
Copy link

Luuckyy commented Feb 24, 2025

What happened?

The implementation of include_aliases isn't done as it should be, as stated in the documentation we should be able to use any alias or the standards, onesignal_id or external_id. Right now it is set to alias_label which is a set label you would need to use in onesignal.
See include_aliases usage

Steps to reproduce?

1. Install gem with readme.md
2. Initialize config in config.file (would likely be in config/initializers/one_signal.rb)
3. try to send a notification using include_aliases and the key onesignal_id

What did you expect to happen?

I expected to use this
included_aliases = OneSignal::PlayerNotificationTargetIncludeAliases.new( onesignal_id: ['1'] )
which would have created a notification sent to the users with the onesignal_id '1'

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Luuckyy Luuckyy added the bug label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant