Skip to content

Commit f40c82b

Browse files
committed
fix people page
- set a max size for avatar - only show the team title if there's member in it
1 parent ffc5d4e commit f40c82b

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

_includes/helpers/new_team.html

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% comment %}
22
New Team Helper
3-
3+
44
Create a new team that can be included in the people's page.
55
{% endcomment %}
66

@@ -18,12 +18,14 @@ <h2>{{ include.name }}</h2>
1818
<div class="card-section">
1919
{% include helpers/avatar_exists.html %}
2020
{% if avatar_exists == "true" %}
21-
<img src="{{ avatar_path_exists }}"
21+
<img src="{{ avatar_path_exists }}"
2222
class="rounded"
2323
width="128"
24+
height="128"
25+
style="max-height: 128px; max-width: 128px;"
2426
alt="Profile Picture's of {{ person[1].name }}">
2527
{% elsif avatar_exists == "false" %}
26-
<img src="/assets/img/osm/osm-avatar-default.png"
28+
<img src="/assets/img/osm/osm-avatar-default.png"
2729
class="rounded"
2830
width="128"
2931
aria-hidden="true"

people.html

+19-3
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,33 @@
66

77
<div class="grid-container">
88
{% for person in site.data.people %}
9+
{% if person[1].team == "steering-committee" %}
10+
{% assign steering = true %}
11+
{% endif %}
912
{% if person[1].team == "code-of-conduct-committee" %}
1013
{% assign coc = true %}
1114
{% endif %}
15+
{% if person[1].team == "advisors" %}
16+
{% assign advisors = true %}
17+
{% endif %}
18+
{% if person[1].team == "production" %}
19+
{% assign production = true %}
20+
{% endif %}
1221
{% endfor %}
1322

14-
{% include helpers/new_team.html name="Steering Committee" %}
23+
{% if steering %}
24+
{% include helpers/new_team.html name="Steering Committee" %}
25+
{% endif %}
1526

1627
{% if coc %}
1728
{% include helpers/new_team.html name="Code of Conduct Committee" %}
1829
{% endif %}
1930

20-
{% include helpers/new_team.html name="Advisors" %}
21-
{% include helpers/new_team.html name="Production" %}
31+
{% if advisors %}
32+
{% include helpers/new_team.html name="Advisors" %}
33+
{% endif %}
34+
35+
{% if production %}
36+
{% include helpers/new_team.html name="Production" %}
37+
{% endif %}
2238
</div>

0 commit comments

Comments
 (0)