diff --git a/app/src/organisms/ODD/QuickTransferFlow/Aspirate/index.tsx b/app/src/organisms/ODD/QuickTransferFlow/Aspirate/index.tsx index 93a0f57a278..961775bfdc9 100644 --- a/app/src/organisms/ODD/QuickTransferFlow/Aspirate/index.tsx +++ b/app/src/organisms/ODD/QuickTransferFlow/Aspirate/index.tsx @@ -1,10 +1,8 @@ -import { useState, useEffect } from 'react' +import { useState } from 'react' import { useTranslation } from 'react-i18next' import { DIRECTION_COLUMN, Flex, SPACING } from '@opentrons/components' -import { ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB } from '/app/redux/analytics' -import { useTrackEventWithRobotSerial } from '/app/redux-resources/analytics' import { MediumButton } from '/app/atoms/buttons' import { AspirateSettingItem } from './AspirateSettingItem' import { AspirateSettingDetail } from './AspirateSettingDetail' @@ -30,14 +28,6 @@ export function Aspirate(props: AspirateProps): JSX.Element | null { selectedSetting, setSelectedSetting, ] = useState(null) - const { trackEventWithRobotSerial } = useTrackEventWithRobotSerial() - - useEffect(() => { - trackEventWithRobotSerial({ - name: ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB, - properties: {}, - }) - }, []) const aspirateSettingsItems = useAspirateSettingsConfig({ state, diff --git a/app/src/organisms/ODD/QuickTransferFlow/Dispense/index.tsx b/app/src/organisms/ODD/QuickTransferFlow/Dispense/index.tsx index 105319cdc29..781104c1831 100644 --- a/app/src/organisms/ODD/QuickTransferFlow/Dispense/index.tsx +++ b/app/src/organisms/ODD/QuickTransferFlow/Dispense/index.tsx @@ -1,11 +1,9 @@ -import { useState, useEffect } from 'react' +import { useState } from 'react' import { useTranslation } from 'react-i18next' import { DIRECTION_COLUMN, Flex, SPACING } from '@opentrons/components' import { MediumButton } from '/app/atoms/buttons' -import { ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB } from '/app/redux/analytics' -import { useTrackEventWithRobotSerial } from '/app/redux-resources/analytics' import { DispenseSettingDetail } from './DispenseSettingDetail' import { DispenseSettingItem } from './DispenseSettingItem' import { useDispenseSettingsConfig } from './hooks/useDispenseSettingsConfig' @@ -31,19 +29,11 @@ export function Dispense(props: DispenseProps): JSX.Element | null { selectedSetting, setSelectedSetting, ] = useState(null) - const { trackEventWithRobotSerial } = useTrackEventWithRobotSerial() const dispenseSettingsItems = useDispenseSettingsConfig({ state, setSelectedSetting, }) - useEffect(() => { - trackEventWithRobotSerial({ - name: ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB, - properties: {}, - }) - }, []) - return ( { let props: ComponentProps @@ -166,12 +162,6 @@ describe('Aspirate', () => { vi.mocked(useAspirateSettingsConfig).mockReturnValue( mockAspirateSettingsItems ) - mockTrackEventWithRobotSerial = vi.fn( - () => new Promise(resolve => resolve({})) - ) - vi.mocked(useTrackEventWithRobotSerial).mockReturnValue({ - trackEventWithRobotSerial: mockTrackEventWithRobotSerial, - }) }) it('renders mock components and reset button', () => { diff --git a/app/src/organisms/ODD/QuickTransferFlow/__tests__/Dispense/Dispense.test.tsx b/app/src/organisms/ODD/QuickTransferFlow/__tests__/Dispense/Dispense.test.tsx index d0296e80493..81d79430dc8 100644 --- a/app/src/organisms/ODD/QuickTransferFlow/__tests__/Dispense/Dispense.test.tsx +++ b/app/src/organisms/ODD/QuickTransferFlow/__tests__/Dispense/Dispense.test.tsx @@ -1,7 +1,6 @@ import { describe, it, vi, beforeEach, expect } from 'vitest' import { screen } from '@testing-library/react' -import { useTrackEventWithRobotSerial } from '/app/redux-resources/analytics' import { renderWithProviders } from '/app/__testing-utils__' import { i18n } from '/app/i18n' @@ -12,7 +11,6 @@ import { Dispense } from '../../Dispense' import type { ComponentProps } from 'react' -vi.mock('/app/redux-resources/analytics') vi.mock('../../Dispense/DispenseSettingItem') vi.mock('../../Dispense/DispenseSettingDetail') vi.mock('../../Dispense/hooks/useAspirateSettingsConfig') @@ -23,8 +21,6 @@ const render = (props: ComponentProps) => { }) } -let mockTrackEventWithRobotSerial: any - describe('Dispense', () => { let props: ComponentProps @@ -94,12 +90,6 @@ describe('Dispense', () => { vi.mocked(DispenseSettingDetail).mockReturnValue(
mock DispenseSettingDetail
) - mockTrackEventWithRobotSerial = vi.fn( - () => new Promise(resolve => resolve({})) - ) - vi.mocked(useTrackEventWithRobotSerial).mockReturnValue({ - trackEventWithRobotSerial: mockTrackEventWithRobotSerial, - }) }) it('renders mock components and reset button', () => { diff --git a/app/src/redux/analytics/constants.ts b/app/src/redux/analytics/constants.ts index b58a70878f8..4c0d31263ef 100644 --- a/app/src/redux/analytics/constants.ts +++ b/app/src/redux/analytics/constants.ts @@ -82,6 +82,7 @@ export const ANALYTICS_QUICK_TRANSFER_FLOW_STARTED = 'quickTransferFlowStarted' export const ANALYTICS_QUICK_TRANSFER_WELL_SELECTION_DURATION = 'quickTransferWellSelectionDuration' export const ANALYTICS_QUICK_TRANSFER_EXIT_EARLY = 'quickTransferExitEarly' +// ToDo(kk:04/11/2025) the following two tab events will be removed when ff is removed export const ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB = 'quickTransferAdvancedSettingsTab' export const ANALYTICS_QUICK_TRANSFER_TIP_MANAGEMENT_TAB =