Skip to content

Use std::sync::LazyLock instead of lazy_static #3951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

FalkWoldmann
Copy link
Contributor

fixes #3950

@fabricereix
Copy link
Collaborator

Thanks @FalkWoldmann for your PR
just a few remarks:

  • It's a good thing to reformat the TOML, but we would prefer to have it in a different PR
  • could you add in the issue the source (link) that recommended/motivated this change?

@FalkWoldmann
Copy link
Contributor Author

Thanks for the quick review! I will move the formatting changes to a separate PR asap.

Regarding your second remark: I am not quite sure what you mean by source regarding the change. Could you maybe clarify that a little more? Thanks!

@jcamiel
Copy link
Collaborator

jcamiel commented Apr 6, 2025

@fabricereix see announcement here https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html LazyLock is now in the standard library and can replace a third party crate lazy_static

@fabricereix
Copy link
Collaborator

Yes, this link/reference is good to me
I think it is good to add it as documentation/motivation

@FalkWoldmann
Copy link
Contributor Author

I reverted the formatting and added the link to the issue as context

@fabricereix
Copy link
Collaborator

sorry @FalkWoldmann to be a bit pedantic
could you squash your commits?
thanks

@FalkWoldmann
Copy link
Contributor Author

done

@fabricereix
Copy link
Collaborator

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Apr 8, 2025

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Apr 8, 2025

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, FalkWoldmann/hurl/remove_lazy_static now embeds these commits:

@hurl-bot hurl-bot force-pushed the remove_lazy_static branch from f2c7bde to bfa08cf Compare April 8, 2025 05:40
@hurl-bot
Copy link
Collaborator

hurl-bot commented Apr 8, 2025

🕗 /accept is still running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Apr 8, 2025

✅ Pull request merged with fast forward by fabricereix..

# List of commits merged from FalkWoldmann/hurl/remove_lazy_static branch into Orange-OpenSource/hurl/master branch:

  • bfa08cf Use std::sync::LazyLock instead of lazy_static

@hurl-bot hurl-bot merged commit bfa08cf into Orange-OpenSource:master Apr 8, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace lazy_static with std equivalent LazyLock
4 participants