Skip to content

Commit 106aa57

Browse files
authored
chore: allow PHP 8.4 (#10)
1 parent 3fafa2e commit 106aa57

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/ci.yml

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
- php: "8.1"
1919
- php: "8.2"
2020
- php: "8.3"
21+
- php: "8.4"
2122
steps:
2223
- name: Checkout source
2324
uses: actions/checkout@v4

src/ExecutionException.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ final class ExecutionException extends \RuntimeException
2020
*/
2121
private $result;
2222

23-
public function __construct(CliResult $result, $message = '', $code = 0, \Exception $previous = null)
23+
public function __construct(CliResult $result, $message = '', $code = 0, ?\Exception $previous = null)
2424
{
2525
parent::__construct($message, $code, $previous);
2626

src/ScriptExecutor.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ final class ScriptExecutor
5151
* @param string[] $scriptParts
5252
* @param ?string[] $scriptInit
5353
*/
54-
public function __construct(array $scriptParts, string $cwd, array $scriptInit = null)
54+
public function __construct(array $scriptParts, string $cwd, ?array $scriptInit = null)
5555
{
5656
$this->scriptParts = $scriptParts;
5757
$this->cwd = $cwd;
@@ -69,7 +69,7 @@ public function __destruct()
6969
* @param string[] $scriptParts
7070
* @param ?string[] $scriptInit
7171
*/
72-
public static function create(array $scriptParts, string $cwd, array $scriptInit = null): self
72+
public static function create(array $scriptParts, string $cwd, ?array $scriptInit = null): self
7373
{
7474
return new self($scriptParts, $cwd, $scriptInit);
7575
}

0 commit comments

Comments
 (0)