target/ppc: Optimize hashchkp and hashstp when in CONFIG_USER_ONLY

Add a method equivalent to CHK_SV that works with decodetree.
Use it in hash instructions to optimize when CONFIG_USER_ONLY
is defined.

Suggested-by: Matheus Ferst <[email protected]>
Signed-off-by: Víctor Colombo <[email protected]>

Author: vcoracolombo

target/ppc/translate.c

@@ -1300,6 +1300,18 @@ typedef struct opcode_t {
 
 #define CHK_NONE
 
+/* Helper for priv. check to be used in decodetree */
+static inline bool do_check_sv(DisasContext *ctx)
+{
+#if !defined(CONFIG_USER_ONLY)
+    if (likely(ctx->pr != 0)) {
+        return false;
+    }
+#endif
+    gen_priv_exception(ctx, POWERPC_EXCP_PRIV_OPC);
+    return true;
+}
+
 /*****************************************************************************/
 /* PowerPC instructions table                                                */
 

target/ppc/translate/fixedpoint-impl.c.inc

@@ -503,10 +503,9 @@ static bool do_hash(DisasContext *ctx, arg_X *a, bool priv,
         return true;
     }
 
-    if (unlikely(priv && ctx->pr)) {
+    if (unlikely(priv && do_check_sv(ctx))) {
         /* if instruction is privileged but the context is in user space */
-        gen_priv_exception(ctx, POWERPC_EXCP_PRIV_OPC);
-        return 0;
+        return true;
     }
 
     if (a->ra == 0) {