TDP-1887 Don't init a SplitIO factory twice, even if the original was NULL. Pass a splitFile path instead of overriding system functionsi for testing.

Author: derekrprice

README.md

@@ -81,5 +81,19 @@ You need to set the toggle "key" somewhere.  This is usually something like a us
     ];
 
 ## Testing
+### This Project
+    composer test
 
-    composer test
+### Your Project
+The SplitIO SDK throws errors when it can't find a configuration file in localhost mode.  To work around that, create a dummy local `split.yaml` file and ask the factory to load it.  For example, you can set SPLITIO_SPLIT_FILE in your testing environment to point to your file:
+
+    # .env.testing
+    SPLITIO_SPLIT_FILE=tests/__data__/split.yaml
+
+This assumes a file like this one at `tests/__data__/split.yaml`:
+
+    - hello_world:
+      treatment: off
+    - hello_world:
+      treatment: on
+      keys: "[email protected]"

config/feature-toggle.php

@@ -22,7 +22,9 @@
                 ]
             ],
 
-            'log' => ['adapter' => 'stdout', 'level' => 'error']
-        ]
-    ]
+            'log' => ['adapter' => 'stdout', 'level' => 'error'],
+
+            'splitFile' => env('SPLITIO_SPLIT_FILE'),
+        ],
+    ],
 ];

phpunit.xml

@@ -20,6 +20,7 @@
         <server name="MAIL_DRIVER" value="array"/>
         <server name="QUEUE_CONNECTION" value="sync"/>
         <server name="SESSION_DRIVER" value="array"/>
+        <server name="SPLITIO_SPLIT_FILE" value="tests/__data__/split.yaml"/>
     </php>
     <logging>
         <log type="junit" target="./junit.xml"/>

src/FeatureToggleClientProvider.php

@@ -47,10 +47,13 @@ public function boot()
     {
         $this->publishes([
             __DIR__.'/../config/feature-toggle.php' => config_path('feature-toggle.php'),
+            'config'
         ]);
     }
 
+    private static $splitIOFactoryInitialized = false;
     private static $splitIOFactory;
+
     /**
      * Return the singleton factory instance.  This is only needed for testing, since
      * SplitIO enforces a singleton factory by returning an error the second time one
@@ -62,12 +65,13 @@ public function boot()
      *
      * @return SplitFactoryInterface
      */
-    private static function getSplitIOFactory(): SplitFactoryInterface {
-        if (!static::$splitIOFactory) {
+    private static function getSplitIOFactory(): ?SplitFactoryInterface {
+        if (!static::$splitIOFactoryInitialized) {
             static::$splitIOFactory = Sdk::factory(
                 config('feature-toggle.splitio.api_key'),
                 config('feature-toggle.splitio.factory')
             );
+            static::$splitIOFactoryInitialized = true;
         }
 
         return static::$splitIOFactory;

src/Lib/SplitIOFeatureToggleClient.php

@@ -14,7 +14,7 @@ class SplitIOFeatureToggleClient implements FeatureToggleClient {
 
     function __construct(SplitFactoryInterface $factory) {
         $this->splitFactory = $factory;
-        $this->splitClient = $factory->client();
+        $this->splitClient = optional($factory)->client();
     }
 
     public function setAttributes($attributes) {

tests/SplitIOTest.php

@@ -1,10 +1,5 @@
 <?php
 
-namespace SplitIO\Sdk;
-function posix_getpwuid() {
-    return ['dir' => __DIR__ . '/__data__'];
-}
-
 namespace PartehGSS\Laravel\FreatureToggle\Tests;
 
 use PartechGSS\Laravel\FeatureToggle\Contracts\FeatureToggleClient;
@@ -16,7 +11,6 @@ protected function getPackageProviders($app)
         return [FeatureToggleClientProvider::class];
     }
 
-
     /**
      * Test that the control treatment is returned for a non-existant flag.
      * @test