Skip to content

Commit ffcd21d

Browse files
committed
TDP-1887 Defer provider creation.
1 parent 623feef commit ffcd21d

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/FeatureToggleClientProvider.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
namespace PartechGSS\Laravel\FeatureToggle;
44

55
use Exception;
6+
use Illuminate\Contracts\Support\DeferrableProvider;
67
use PartechGSS\Laravel\FeatureToggle\Contracts\FeatureToggleClient;
78
use PartechGSS\Laravel\FeatureToggle\Lib\SplitIOFeatureToggleClient;
8-
use Illuminate\Http\Request;
99
use Illuminate\Support\Facades\Log;
1010
use Illuminate\Support\ServiceProvider;
1111
use SplitIO\Sdk;
1212
use SplitIO\Sdk\Factory\SplitFactoryInterface;
1313

14-
class FeatureToggleClientProvider extends ServiceProvider
14+
class FeatureToggleClientProvider extends ServiceProvider implements DeferrableProvider
1515
{
1616
/**
1717
* Register services.

tests/SplitIOTest.php

+4
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@ protected function getPackageProviders($app)
1616
return [FeatureToggleClientProvider::class];
1717
}
1818

19+
1920
/**
2021
* Test that the control treatment is returned for a non-existant flag.
2122
* @test
2223
* @return void
2324
*/
2425
public function it_renders_the_control_treatment() {
26+
config()->set('feature-toggle.splitio.factory.log.adapter', 'void');
2527
$toggleClient = app(FeatureToggleClient::class);
2628
$toggleClient->setKey("[email protected]");
2729
$this->assertEquals("control", $toggleClient->getTreatment("AintNoSuchFlag"));
@@ -44,6 +46,7 @@ public function it_renders_the_control_treatment_without_key() {
4446
* @return void
4547
*/
4648
public function it_renders_an_off_treatment() {
49+
config()->set('feature-toggle.splitio.factory.log.adapter', 'void');
4750
$toggleClient = app(FeatureToggleClient::class);
4851
$toggleClient->setKey("[email protected]");
4952
$this->assertEquals("off", $toggleClient->getTreatment("FancyFeatureFlag"));
@@ -55,6 +58,7 @@ public function it_renders_an_off_treatment() {
5558
* @return void
5659
*/
5760
public function it_renders_an_on_treatment_for_user() {
61+
config()->set('feature-toggle.splitio.factory.log.adapter', 'void');
5862
$toggleClient = app(FeatureToggleClient::class);
5963
$toggleClient->setKey("[email protected]");
6064
$this->assertEquals("on", $toggleClient->getTreatment("FancierFeatureFlag"));

0 commit comments

Comments
 (0)