Skip to content

Commit 66e429e

Browse files
authored
Make typed parameters explicitly nullable (thephpleague#271)
1 parent 2eca382 commit 66e429e

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

src/Common/AbstractGateway.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ abstract class AbstractGateway implements GatewayInterface
6464
* @param ClientInterface $httpClient A HTTP client to make API calls with
6565
* @param HttpRequest $httpRequest A Symfony HTTP request object
6666
*/
67-
public function __construct(ClientInterface $httpClient = null, HttpRequest $httpRequest = null)
67+
public function __construct(?ClientInterface $httpClient = null, ?HttpRequest $httpRequest = null)
6868
{
6969
$this->httpClient = $httpClient ?: $this->getDefaultHttpClient();
7070
$this->httpRequest = $httpRequest ?: $this->getDefaultHttpRequest();

src/Common/CreditCard.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public function addSupportedBrand($name, $expression)
190190
* @param array $parameters An associative array of parameters
191191
* @return $this
192192
*/
193-
public function initialize(array $parameters = null)
193+
public function initialize(?array $parameters = null)
194194
{
195195
$this->parameters = new ParameterBag;
196196

src/Common/GatewayFactory.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public function register($className)
7777
* @throws RuntimeException If no such gateway is found
7878
* @return GatewayInterface An object of class $class is created and returned
7979
*/
80-
public function create($class, ClientInterface $httpClient = null, HttpRequest $httpRequest = null)
80+
public function create($class, ?ClientInterface $httpClient = null, ?HttpRequest $httpRequest = null)
8181
{
8282
$class = Helper::getGatewayClassName($class);
8383

src/Common/Http/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class Client implements ClientInterface
2929
*/
3030
private $requestFactory;
3131

32-
public function __construct($httpClient = null, RequestFactory $requestFactory = null)
32+
public function __construct($httpClient = null, ?RequestFactory $requestFactory = null)
3333
{
3434
$this->httpClient = $httpClient ?: HttpClientDiscovery::find();
3535
$this->requestFactory = $requestFactory ?: MessageFactoryDiscovery::find();

src/Common/Item.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class Item implements ItemInterface
2222
*
2323
* @param array|null $parameters An array of parameters to set on the new object
2424
*/
25-
public function __construct(array $parameters = null)
25+
public function __construct(?array $parameters = null)
2626
{
2727
$this->initialize($parameters);
2828
}
@@ -33,7 +33,7 @@ public function __construct(array $parameters = null)
3333
* @param array|null $parameters An array of parameters to set on this object
3434
* @return $this Item
3535
*/
36-
public function initialize(array $parameters = null)
36+
public function initialize(?array $parameters = null)
3737
{
3838
$this->parameters = new ParameterBag;
3939

src/Omnipay.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public static function getFactory()
8383
*
8484
* @param GatewayFactory $factory A GatewayFactory instance
8585
*/
86-
public static function setFactory(GatewayFactory $factory = null)
86+
public static function setFactory(?GatewayFactory $factory = null)
8787
{
8888
self::$factory = $factory;
8989
}

0 commit comments

Comments
 (0)