MC unit bug when capturing Tech oil derricks.

[Bu7loos]

Description

I encountered a bug when MC units that are able to capture tech oil derricks or any structure that has the tag (ProduceCashStartup=XXXX). MC units can abuse it by capturing the same structure (or multiple one) over and over giving the startup cash more than once.

Can someone please fix this issue. Thank you.

Conditions to reproduce

No response

INI code

No response

Steps to reproduce

Just use a Yuri-Prime with the ability control structures and make sure the tech oil derrick is not mind control immune.

Expected behaviour

See the actual behavior.

Actual behaviour

Start up money abuse, you can get it over and over by MC the same structure over and over.

Additional context

No response

Checklist

• The issue is not introduced by Phobos or any other engine extension, such as Ares, Kratos etc.
• The issue wasn't fixed in the most recent version of Ares/Phobos yet.
• I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
• I added a very descriptive title to this issue.
• I used the GitHub search and read the issue list to find a similar issue and didn't find it.
• I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

[Otamaa]

BuildingClass_ChangeOwnership_ProduceCash is handled by ares , so fixing this probably need some way to access the ares ProduceCashTimers for the Upgrades , unless someone came with clever work around for this .

[Starkku]

BuildingClass_ChangeOwnership_ProduceCash is handled by ares , so fixing this probably need some way to access the ares ProduceCashTimers for the Upgrades , unless someone came with clever work around for this .

Can probably skip the entire portion of code including Ares hook on some condition, after all this is about preventing it from happening more than it should. Only downside is that any such hook would be entered more than it optimally should due to where Ares code is placed.

[Otamaa]

BuildingClass_ChangeOwnership_ProduceCash is handled by ares , so fixing this probably need some way to access the ares ProduceCashTimers for the Upgrades , unless someone came with clever work around for this .

Can probably skip the entire portion of code including Ares hook on some condition, after all this is about preventing it from happening more than it should. Only downside is that any such hook would be entered more than it optimally should due to where Ares code is placed.

ahh , you are right
the derrick money should be provided thru Update function then ?
the ares 0.A code for this seems only checking for timer->GetTimeLeft() == 1 that mean the user wont get any derrick money when capturing it using MC if the BuildingClass_ChangeOwnership_ProduceCash hook is skipped .