Skip to content

update to work with post alpha nightly #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcampbell24 opened this issue Jan 14, 2015 · 4 comments
Closed

update to work with post alpha nightly #238

dcampbell24 opened this issue Jan 14, 2015 · 4 comments
Assignees

Comments

@dcampbell24
Copy link
Member

Conrod is not currently building due to breaking changes released with the alpha.

@dcampbell24 dcampbell24 self-assigned this Jan 14, 2015
@dcampbell24
Copy link
Member Author

The macros need to be updated due to the breaking changes, but I am having trouble figuring out what the proper changes are.

One breaking change is the requirement for a separator between the multiplicative matcher fragment and the fragment before it per RFC 550. My proposal for fixing this is to change for example

($context:ident, $cb:ty $(, $t:ident)*) => ...

to

($context:ident, $cb:ty, $($t:ident),*) => ...

requiring an extra comma at some call sites.

Another breaking change is caused by the changes to closures. I can't figure out how to update impl_callable to handle the new syntax.

Any suggestions?

@dcampbell24
Copy link
Member Author

This is a duplicate of #239 closing.

@dcampbell24
Copy link
Member Author

I am going to rebase #239 and then merge it. So this will serve to track that.

@dcampbell24
Copy link
Member Author

Decided a new PR is not really necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant