Skip to content

Commit b75d86c

Browse files
committed
Ember 3.5 upgrade
1 parent 424e478 commit b75d86c

10 files changed

+2317
-1140
lines changed

.eslintignore

+4
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,13 @@
88

99
# dependencies
1010
/bower_components/
11+
/node_modules/
1112

1213
# misc
1314
/coverage/
15+
!.*
1416

1517
# ember-try
1618
/.node_modules.ember-try/
19+
/bower.json.ember-try
20+
/package.json.ember-try

.eslintrc.js

+2
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ module.exports = {
2222
// node files
2323
{
2424
files: [
25+
'.eslintrc.js',
26+
'.template-lintrc.js',
2527
'ember-cli-build.js',
2628
'index.js',
2729
'testem.js',

.npmignore

+26-19
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,29 @@
1-
/bower_components
1+
# compiled output
2+
/dist/
3+
/tmp/
4+
5+
# dependencies
6+
/bower_components/
7+
8+
# misc
9+
/.bowerrc
10+
/.editorconfig
11+
/.ember-cli
12+
/.eslintignore
13+
/.eslintrc.js
14+
/.gitignore
15+
/.template-lintrc.js
16+
/.travis.yml
17+
/.watchmanconfig
18+
/bower.json
219
/config/ember-try.js
3-
/dist
4-
/tests
5-
/tmp
6-
**/.gitkeep
7-
.bowerrc
8-
.editorconfig
9-
.ember-cli
10-
.eslintrc.js
11-
.gitignore
12-
.watchmanconfig
13-
.travis.yml
14-
bower.json
15-
ember-cli-build.js
16-
testem.js
17-
yarn.lock
20+
/ember-cli-build.js
21+
/testem.js
22+
/tests/
23+
/yarn.lock
24+
.gitkeep
1825

1926
# ember-try
20-
.node_modules.ember-try/
21-
bower.json.ember-try
22-
package.json.ember-try
27+
/.node_modules.ember-try/
28+
/bower.json.ember-try
29+
/package.json.ember-try

.template-lintrc.js

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
extends: 'recommended'
5+
};

.travis.yml

+23-16
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,31 @@ env:
2323
global:
2424
# See https://git.io/vdao3 for details.
2525
- JOBS=1
26-
matrix:
26+
27+
jobs:
28+
fail_fast: true
29+
allow_failures:
30+
- env: EMBER_TRY_SCENARIO=ember-canary
31+
32+
include:
33+
# runs linting and tests with current locked deps
34+
35+
- stage: "Tests"
36+
name: "Tests"
37+
script:
38+
- npm run lint:hbs
39+
- npm run lint:js
40+
- npm test
41+
2742
# we recommend new addons test the current and previous LTS
2843
# as well as latest stable release (bonus points to beta/canary)
29-
- EMBER_TRY_SCENARIO=ember-lts-2.12
30-
- EMBER_TRY_SCENARIO=ember-lts-2.16
31-
- EMBER_TRY_SCENARIO=ember-lts-2.18
32-
- EMBER_TRY_SCENARIO=ember-release
33-
- EMBER_TRY_SCENARIO=ember-beta
34-
- EMBER_TRY_SCENARIO=ember-canary
35-
- EMBER_TRY_SCENARIO=ember-default
36-
37-
matrix:
38-
fast_finish: true
39-
allow_failures:
44+
- stage: "Additional Tests"
45+
env: EMBER_TRY_SCENARIO=ember-lts-2.16
46+
- env: EMBER_TRY_SCENARIO=ember-lts-2.18
47+
- env: EMBER_TRY_SCENARIO=ember-release
48+
- env: EMBER_TRY_SCENARIO=ember-beta
4049
- env: EMBER_TRY_SCENARIO=ember-canary
50+
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
4151

4252
before_install:
4353
- npm config set spin false
@@ -51,7 +61,4 @@ after_success:
5161
- codecov
5262

5363
script:
54-
- npm run lint:js
55-
# Usually, it's ok to finish the test scenario without reverting
56-
# to the addon's original dependency state, skipping "cleanup".
57-
- COVERAGE=true node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
64+
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

config/ember-try.js

+21-8
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,26 @@ module.exports = function() {
1010
]).then((urls) => {
1111
return {
1212
scenarios: [
13-
{
14-
name: 'ember-lts-2.12',
15-
npm: {
16-
devDependencies: {
17-
'ember-source': '~2.12.0'
18-
}
19-
}
20-
},
2113
{
2214
name: 'ember-lts-2.16',
15+
env: {
16+
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
17+
},
2318
npm: {
2419
devDependencies: {
20+
'@ember/jquery': '^0.5.1',
2521
'ember-source': '~2.16.0'
2622
}
2723
}
2824
},
2925
{
3026
name: 'ember-lts-2.18',
27+
env: {
28+
EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true })
29+
},
3130
npm: {
3231
devDependencies: {
32+
'@ember/jquery': '^0.5.1',
3333
'ember-source': '~2.18.0'
3434
}
3535
}
@@ -63,6 +63,19 @@ module.exports = function() {
6363
npm: {
6464
devDependencies: {}
6565
}
66+
},
67+
{
68+
name: 'ember-default-with-jquery',
69+
env: {
70+
EMBER_OPTIONAL_FEATURES: JSON.stringify({
71+
'jquery-integration': true
72+
})
73+
},
74+
npm: {
75+
devDependencies: {
76+
'@ember/jquery': '^0.5.1'
77+
}
78+
}
6679
}
6780
]
6881
};

index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const Funnel = require('broccoli-funnel');
66
const mergeTrees = require('broccoli-merge-trees');
77

88
module.exports = {
9-
name: 'ember-introjs',
9+
name: require('./package').name,
1010

1111
included(app) {
1212
this._super.included(app);
@@ -31,5 +31,5 @@ module.exports = {
3131
});
3232

3333
return tree ? new mergeTrees([tree, introJsTree]) : introJsTree;
34-
},
35-
};
34+
}
35+
}

0 commit comments

Comments
 (0)