From 6e282d6d69712a004543c660ae17374b6f731642 Mon Sep 17 00:00:00 2001 From: Yury Lebedev Date: Fri, 16 Mar 2018 23:56:06 +0300 Subject: [PATCH 1/2] Add RegExp 'global' option to Russian grammar rules --- languages/grammar/ru.json | 2 +- test/grammar_test.js | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/languages/grammar/ru.json b/languages/grammar/ru.json index 6fddfea6a..22d55f87c 100644 --- a/languages/grammar/ru.json +++ b/languages/grammar/ru.json @@ -1,6 +1,6 @@ { "meta": { - "regExpFlags": "" + "regExpFlags": "g" }, "v5": { "accusative": [ diff --git a/test/grammar_test.js b/test/grammar_test.js index 8e30e0978..7c3d744b0 100644 --- a/test/grammar_test.js +++ b/test/grammar_test.js @@ -489,6 +489,8 @@ tape.test('verify grammar files structure', function(assert) { Object.keys(languages.grammars).forEach((l) => { var grammar = languages.grammars[l]; + assert.ok(grammar.meta.regExpFlags.includes('g'), l + ' grammar has "g" regexp option'); + assert.ok(grammar.v5, l + ' grammar has v5 version'); Object.keys(grammar.v5).forEach((g) => { From 7832e4bb8cc1c91cfae17fc32ebdad5f0eb23d2a Mon Sep 17 00:00:00 2001 From: Yury Lebedev Date: Sat, 17 Mar 2018 00:18:02 +0300 Subject: [PATCH 2/2] Changelog entry for required global search option in grammar rules --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 039ec2f14..42aff17c5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file. For change ## master +- Global search option is now required for all grammar rules. [#228] (https://github.com/Project-OSRM/osrm-text-instructions/pull/228) + ## 0.14.0 2019-12-04 - Update Japanese localization, add named intersections. [#290](https://github.com/Project-OSRM/osrm-text-instructions/pull/290)