Skip to content

Wrong Pillar Location #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobnob opened this issue Aug 17, 2020 · 5 comments
Open

Wrong Pillar Location #17

hobnob opened this issue Aug 17, 2020 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hobnob
Copy link
Member

hobnob commented Aug 17, 2020

Affected Scenario(s): 69

Describe the bug
If you open the door on the right of the starting room a pillar appears that does not belong to that room. This pillar actually belongs to rom d2a

To Reproduce
Steps to reproduce the behavior:

  1. Load Scenario 69
  2. Reveal the room to the right
  3. Notice pillar
@hobnob hobnob added the bug Something isn't working label Aug 17, 2020
@hobnob hobnob self-assigned this Aug 17, 2020
@zwh2
Copy link

zwh2 commented Sep 23, 2020

Scenario 69 is loading correctly for me with no pillar in the room to the right of start.

@hobnob
Copy link
Member Author

hobnob commented Sep 25, 2020

Thanks for your feedback @zwh2 . The pillar itself is outside the room and not in the room itself, so it's not a huge issue. If you're still not seeing it, then maybe it's a browser specific issue 🤔

@zwh2
Copy link

zwh2 commented Sep 28, 2020

Ok, now I see what you are talking about. It is the pillar that belongs in the final room. It is in the "correct" place but shows up when the room to the right does. Looking at the json data for scenario 69 it seems like everything is correct so I don't quite understand what could be causing the issue. Any guesses?

@hobnob
Copy link
Member Author

hobnob commented Sep 28, 2020

It's an annoying anomaly - that Pillar is sitting on the point of origin for the previous room 😞 What that means is that when you reveal the second-to-final room, that co-ordinate becomes 'visible' (as it's technically part of that room), erroneously showing the Pillar. I'm not yet confident I know a viable fix yet that doesn't also have some sort of repercussions later on, so I'm pretty much stewing on it while focusing on other things 🙂

@zwh2
Copy link

zwh2 commented Sep 28, 2020

That makes sense. Great tool you have built! I was looking for an easy way to offer some contribution but even this looks like it will be above my ability. Good luck. 👍

@hobnob hobnob added this to the 2.1.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants