Skip to content

Commit eaff751

Browse files
committed
Correct _get_parameters.
The two versions of parameter parsing were not, in fact, equivalent. The return types of `inspect.signature` and `inspect.getargspec` are, in fact, subtly different. See: * https://docs.python.org/3/library/inspect.html#inspect.signature * praw-dev/praw#541 (comment)
1 parent 72e76ab commit eaff751

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pep8.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -1316,7 +1316,10 @@ def _is_eol_token(token, _eol_token=_is_eol_token):
13161316

13171317
def _get_parameters(function):
13181318
if sys.version_info >= (3, 3):
1319-
return list(inspect.signature(function).parameters)
1319+
return [parameter.name
1320+
for parameter
1321+
in inspect.signature(function).parameters.values()
1322+
if parameter.kind == parameter.POSITIONAL_OR_KEYWORD]
13201323
else:
13211324
return inspect.getargspec(function)[0]
13221325

0 commit comments

Comments
 (0)