Skip to content

Commit 94e8f04

Browse files
CI: update minimum Cython version in CI jobs
Also add a comment about `numpy.fft` becoming as fast as `scipy.fft` in 2.0 Co-authored-by: Jarrod Millman <[email protected]>
1 parent a6fc799 commit 94e8f04

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
CYTHON_TRACE: 1
1919
CYTHONSPEC: cython
2020
NUMPY_MIN: numpy==1.23.0
21-
CYTHON_MIN: cython==0.29.35
21+
CYTHON_MIN: cython==3.0.4
2222
SCIPY_MIN: scipy==1.9.0
2323

2424
strategy:
@@ -130,7 +130,7 @@ jobs:
130130
CYTHON_TRACE: 1
131131
CYTHONSPEC: cython
132132
NUMPY_MIN: numpy==1.23.0
133-
CYTHON_MIN: cython==0.29.35
133+
CYTHON_MIN: cython==3.0.4
134134
SCIPY_MIN: scipy==1.9.0
135135

136136
strategy:

pywt/_cwt.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
fftmodule = np.fft
2222

2323
# provide a fallback so scipy is an optional requirement
24+
# note: numpy.fft in numpy 2.0 is as fast as scipy.fft, so could be used
25+
# unconditionally once the minimum supported numpy version is >=2.0
2426
def next_fast_len(n):
2527
"""Round up size to the nearest power of two.
2628

0 commit comments

Comments
 (0)