Skip to content

Commit 53c29de

Browse files
authored
Merge pull request #1036 from Pythagora-io/app-finished
add more info to appFinished event for extension
2 parents b78ffac + 3fb38cd commit 53c29de

File tree

5 files changed

+84
-14
lines changed

5 files changed

+84
-14
lines changed

core/agents/task_completer.py

+10-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,16 @@ async def run(self) -> AgentResponse:
3838

3939
if current_task_index1 == len(tasks):
4040
if source == "app":
41-
await self.ui.send_app_finished()
41+
await self.ui.send_app_finished(
42+
app_id=str(self.state_manager.project.id),
43+
app_name=self.state_manager.project.name,
44+
folder_name=self.state_manager.project.folder_name,
45+
)
4246
elif source == "feature":
43-
await self.ui.send_feature_finished()
47+
await self.ui.send_feature_finished(
48+
app_id=str(self.state_manager.project.id),
49+
app_name=self.state_manager.project.name,
50+
folder_name=self.state_manager.project.folder_name,
51+
)
4452

4553
return AgentResponse.done(self)

core/ui/base.py

+20-2
Original file line numberDiff line numberDiff line change
@@ -121,15 +121,33 @@ async def send_key_expired(self, message: Optional[str] = None):
121121
"""
122122
raise NotImplementedError()
123123

124-
async def send_app_finished(self):
124+
async def send_app_finished(
125+
self,
126+
app_id: Optional[str] = None,
127+
app_name: Optional[str] = None,
128+
folder_name: Optional[str] = None,
129+
):
125130
"""
126131
Send the app finished message.
132+
133+
:param app_id: App ID.
134+
:param app_name: App name.
135+
:param folder_name: Folder name.
127136
"""
128137
raise NotImplementedError()
129138

130-
async def send_feature_finished(self):
139+
async def send_feature_finished(
140+
self,
141+
app_id: Optional[str] = None,
142+
app_name: Optional[str] = None,
143+
folder_name: Optional[str] = None,
144+
):
131145
"""
132146
Send the feature finished message.
147+
148+
:param app_id: App ID.
149+
:param app_name: App name.
150+
:param folder_name: Folder name.
133151
"""
134152
raise NotImplementedError()
135153

core/ui/console.py

+13-3
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,24 @@ async def send_message(self, message: str, *, source: Optional[UISource] = None)
3333
else:
3434
print(message)
3535

36-
async def send_key_expired(self, message: Optional[str]):
36+
async def send_key_expired(self, message: Optional[str] = None):
3737
if message:
3838
await self.send_message(message)
3939

40-
async def send_app_finished(self):
40+
async def send_app_finished(
41+
self,
42+
app_id: Optional[str] = None,
43+
app_name: Optional[str] = None,
44+
folder_name: Optional[str] = None,
45+
):
4146
pass
4247

43-
async def send_feature_finished(self):
48+
async def send_feature_finished(
49+
self,
50+
app_id: Optional[str] = None,
51+
app_name: Optional[str] = None,
52+
folder_name: Optional[str] = None,
53+
):
4454
pass
4555

4656
async def ask_question(

core/ui/ipc_client.py

+28-4
Original file line numberDiff line numberDiff line change
@@ -199,11 +199,35 @@ async def send_message(self, message: str, *, source: Optional[UISource] = None)
199199
async def send_key_expired(self, message: Optional[str] = None):
200200
await self._send(MessageType.KEY_EXPIRED)
201201

202-
async def send_app_finished(self):
203-
await self._send(MessageType.APP_FINISHED)
202+
async def send_app_finished(
203+
self,
204+
app_id: Optional[str] = None,
205+
app_name: Optional[str] = None,
206+
folder_name: Optional[str] = None,
207+
):
208+
await self._send(
209+
MessageType.APP_FINISHED,
210+
content={
211+
"app_id": app_id,
212+
"app_name": app_name,
213+
"folder_name": folder_name,
214+
},
215+
)
204216

205-
async def send_feature_finished(self):
206-
await self._send(MessageType.FEATURE_FINISHED)
217+
async def send_feature_finished(
218+
self,
219+
app_id: Optional[str] = None,
220+
app_name: Optional[str] = None,
221+
folder_name: Optional[str] = None,
222+
):
223+
await self._send(
224+
MessageType.FEATURE_FINISHED,
225+
content={
226+
"app_id": app_id,
227+
"app_name": app_name,
228+
"folder_name": folder_name,
229+
},
230+
)
207231

208232
async def ask_question(
209233
self,

core/ui/virtual.py

+13-3
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,23 @@ async def send_message(self, message: str, *, source: Optional[UISource] = None)
3434
else:
3535
print(message)
3636

37-
async def send_key_expired(self, message: Optional[str]):
37+
async def send_key_expired(self, message: Optional[str] = None):
3838
pass
3939

40-
async def send_app_finished(self):
40+
async def send_app_finished(
41+
self,
42+
app_id: Optional[str] = None,
43+
app_name: Optional[str] = None,
44+
folder_name: Optional[str] = None,
45+
):
4146
pass
4247

43-
async def send_feature_finished(self):
48+
async def send_feature_finished(
49+
self,
50+
app_id: Optional[str] = None,
51+
app_name: Optional[str] = None,
52+
folder_name: Optional[str] = None,
53+
):
4454
pass
4555

4656
async def ask_question(

0 commit comments

Comments
 (0)