Skip to content

History Request: Option: missed empty bars #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Romazes opened this issue Feb 21, 2025 · 0 comments
Open

History Request: Option: missed empty bars #11

Romazes opened this issue Feb 21, 2025 · 0 comments
Assignees
@Romazes
Labels
bug Something isn't working

Comments

@Romazes
Copy link
Collaborator

Romazes commented Feb 21, 2025

Expected Behavior

Returns All bars even the API returns zero result of some properties.

Actual Behavior

We have skipped bars in code base.

Potential Solution

Remove condition and test with GetHistoryRequestWithCalculateAmountReturnsData
Image

Reproducing the Problem

Use Option Symbol with any resolution in GetHistoryRequestWithCalculateAmountReturnsData test.

[TestCase("AAPL", SecurityType.Option, Resolution.Minute, "2025/02/19", "2025/02/20", new[] { TickType.Quote, TickType.Trade })]

System Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Romazes Romazes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Romazes