Skip to content

Commit 154dcce

Browse files
committed
Don't log file no exist errors when creating mapset banner/preview
1 parent 7306866 commit 154dcce

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

handlers/mapset_submission.go

+7-4
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ var (
4848

4949
const (
5050
__MACOSX string = "__MACOSX"
51+
52+
errBannerFileNoExists string = "could not create mapset banner (file no exists)"
53+
errAudioPreviewFileNoExists string = "could not create audio preview (file no exists)"
5154
)
5255

5356
// HandleMapsetSubmission Handles the uploading/updating of a mapset archive (.qp) file
@@ -129,11 +132,11 @@ func HandleMapsetSubmission(c *gin.Context) *APIError {
129132
}
130133

131134
go func() {
132-
if err := createMapsetBanner(zipReader, quaFiles); err != nil {
135+
if err := createMapsetBanner(zipReader, quaFiles); err != nil && err.Error() != errBannerFileNoExists {
133136
logrus.Warning("Error creating mapset banner: ", err)
134137
}
135138

136-
if err := createAudioPreviewFromZip(zipReader, quaFiles); err != nil {
139+
if err := createAudioPreviewFromZip(zipReader, quaFiles); err != nil && err.Error() != errAudioPreviewFileNoExists {
137140
logrus.Warning("Error creating audio file: ", err)
138141
}
139142
}()
@@ -683,7 +686,7 @@ func createMapsetBanner(zip *zip.Reader, quaFiles map[*zip.File]*qua.Qua) error
683686
}
684687
}
685688

686-
return errors.New("could not create mapset banner (file no exists)")
689+
return errors.New(errBannerFileNoExists)
687690
}
688691

689692
// Creates an auto-cropped mapset banner and uploads it to azure
@@ -766,7 +769,7 @@ func createAudioPreviewFromZip(zip *zip.Reader, quaFiles map[*zip.File]*qua.Qua)
766769
}
767770
}
768771

769-
return errors.New("could not create audio preview (file no exists)")
772+
return errors.New(errAudioPreviewFileNoExists)
770773
}
771774

772775
// Uses FFMPEG to create an audio preview from a file path

0 commit comments

Comments
 (0)