Skip to content

Commit 309e4d8

Browse files
authored
Merge pull request #163 from QuickBlox/gh-pages.attach_attrs
parseExtraParams() was updated
2 parents 4e00f10 + ea50ea5 commit 309e4d8

File tree

6 files changed

+19
-16
lines changed

6 files changed

+19
-16
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ For correct work of JS SDK you must include the library in your html before `qu
2020

2121
```html
2222
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>
23-
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.1/quickblox.min.js"></script>
23+
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.2/quickblox.min.js"></script>
2424
```
2525

2626
## Bower and RequireJS

bower.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.1",
4+
"version": "2.3.2",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "quickblox.js",
77
"license": "Apache 2.0",
@@ -20,7 +20,8 @@
2020
"authors": [
2121
"Igor Khomenko <[email protected]>",
2222
"Vlad Lukhanin <[email protected]>",
23-
"Dima Lobanov <[email protected]>"
23+
"Dima Lobanov <[email protected]>",
24+
"Iegor Kozakov <[email protected]>"
2425
],
2526
"repository": {
2627
"type": "git",

package.json

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.1",
4+
"version": "2.3.2",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "src/qbMain.js",
77
"license" : "(Apache-2.0)",
@@ -20,12 +20,14 @@
2020
"maintainers": [
2121
"Igor Khomenko <[email protected]>",
2222
"Vlad Lukhanin <[email protected]>",
23-
"Dima Lobanov <[email protected]>"
23+
"Dima Lobanov <[email protected]>",
24+
"Iegor Kozakov <[email protected]>"
2425
],
2526
"contributors": [
2627
"Igor Khomenko <[email protected]>",
2728
"Vlad Lukhanin <[email protected]>",
28-
"Dima Lobanov <[email protected]>"
29+
"Dima Lobanov <[email protected]>",
30+
"Iegor Kozakov <[email protected]>"
2931
],
3032
"repository": {
3133
"type": "git",

quickblox.min.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/modules/qbChatHelpers.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ var qbChatHelpers = {
3232

3333
if ('userId' in params) {
3434
jid = params.userId + '-' + config.creds.appId + '@' + config.endpoints.chat;
35-
35+
3636
if ('resource' in params) {
3737
jid = userJid + "/" + params.resource;
3838
}
@@ -96,9 +96,9 @@ var qbChatHelpers = {
9696
},
9797
_JStoXML: function(title, obj, msg) {
9898
var self = this;
99-
99+
100100
msg.c(title);
101-
101+
102102
Object.keys(obj).forEach(function(field) {
103103
if (typeof obj[field] === 'object') {
104104
self._JStoXML(field, obj[field], msg);
@@ -165,7 +165,7 @@ var qbChatHelpers = {
165165
var attributes = extraParams.childNodes[i].attributes;
166166

167167
for (var j = 0, len2 = attributes.length; j < len2; j++) {
168-
if (attributes[j].name === 'id' || attributes[j].name === 'size'){
168+
if (attributes[j].name === 'size'){
169169
attach[attributes[j].name] = parseInt(attributes[j].value);
170170
} else {
171171
attach[attributes[j].name] = attributes[j].value;
@@ -209,7 +209,7 @@ var qbChatHelpers = {
209209
dialogId = extraParams.getChildText('dialog_id');
210210
extension['dialog_id'] = dialogId;
211211
}
212-
212+
213213
if(extraParams.children[i].children.length === 1) {
214214
var child = extraParams.children[i];
215215

@@ -243,7 +243,7 @@ var qbChatHelpers = {
243243
var errorElement = stanzaError.getElementsByTagName('error')[0];
244244
var errorCode = parseInt(errorElement.getAttribute('code'));
245245
var errorText = errorElement.getElementsByTagName('text')[0].textContent;
246-
246+
247247
return utils.getError(errorCode, errorText);
248248
},
249249
getLocalTime: function() {

src/qbConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
var config = {
13-
version: '2.3.1',
13+
version: '2.3.2',
1414
creds: {
1515
appId: '',
1616
authKey: '',

0 commit comments

Comments
 (0)