Skip to content

Commit d552887

Browse files
authored
Merge pull request #171 from QuickBlox/gh-pages.msgId
gh-pages.msgId
2 parents 8666897 + f3e94b2 commit d552887

File tree

7 files changed

+24
-19
lines changed

7 files changed

+24
-19
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ For correct work of JS SDK you must include the library in your html before `qu
2020

2121
```html
2222
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script>
23-
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.3/quickblox.min.js"></script>
23+
<script src="https://cdnjs.cloudflare.com/ajax/libs/quickblox/2.3.4/quickblox.min.js"></script>
2424
```
2525

2626
## Bower and RequireJS

bower.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.3",
4+
"version": "2.3.4",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "quickblox.js",
77
"license": "Apache 2.0",

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "2.3.3",
4+
"version": "2.3.4",
55
"homepage": "https://quickblox.com/developers/Javascript",
66
"main": "src/qbMain.js",
77
"license" : "(Apache-2.0)",

quickblox.min.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/QB-ChatSpec.js

+11-10
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,13 @@ describe('Chat API', function() {
6868
body: body,
6969
extension: msgExtension,
7070
markable: 1
71-
};
71+
};
7272

7373
function onMsgCallback(userId, receivedMessage) {
7474
expect(userId).toEqual(QBUser1.id);
7575

7676
expect(receivedMessage).toBeDefined();
77+
expect(receivedMessage.id).toEqual(msg.id);
7778
expect(receivedMessage.type).toEqual(msg.type);
7879
expect(receivedMessage.body).toEqual(body);
7980
expect(receivedMessage.extension).toEqual(msgExtension);
@@ -83,31 +84,31 @@ describe('Chat API', function() {
8384
}
8485

8586
QB.chat.onMessageListener = onMsgCallback;
86-
QB.chat.send(QBUser1.id, msg);
87+
msg.id = QB.chat.send(QBUser1.id, msg);
8788
}, MESSAGING_TIMEOUT);
8889

8990
it('can send and receive system message', function(done) {
9091
var msg = {
91-
body: 'Notification',
92-
extension:{
93-
name: 'Walle',
94-
action: 'Found love'
95-
}
96-
};
92+
body: 'Notification',
93+
extension:{
94+
name: 'Walle',
95+
action: 'Found love'
96+
}
97+
};
9798

9899
function onSystemMessageListenerCb(receivedMessage) {
99100
expect(receivedMessage).toBeDefined();
100101

101102
expect(receivedMessage.userId).toEqual(QBUser1.id);
103+
expect(receivedMessage.id).toEqual(msg.id);
102104
expect(receivedMessage.body).toEqual(msg.body);
103105
expect(receivedMessage.extension).toEqual(msg.extension);
104106

105107
done();
106108
}
107109

108110
QB.chat.onSystemMessageListener = onSystemMessageListenerCb;
109-
110-
QB.chat.sendSystemMessage(QBUser1.id, msg);
111+
msg.id = QB.chat.sendSystemMessage(QBUser1.id, msg);
111112
}, MESSAGING_TIMEOUT);
112113

113114
it('can send and receive \'delivered\' status', function(done) {

src/modules/qbChat.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,8 @@ ChatProxy.prototype = {
609609

610610
nClient.send(stanza);
611611
}
612+
613+
return paramsCreateMsg.id;
612614
},
613615
sendSystemMessage: function(jid_or_user_id, message) {
614616
var self = this,
@@ -634,7 +636,7 @@ ChatProxy.prototype = {
634636
xmlns: chatUtils.MARKERS.CLIENT
635637
}).c('moduleIdentifier').t('SystemNotifications').up();
636638

637-
stanza = chatUtils.filledExtraParams(stanza, message.extension);
639+
stanza = chatUtils.filledExtraParams(stanza, message.extension);
638640
}
639641

640642
connection.send(stanza);
@@ -651,6 +653,8 @@ ChatProxy.prototype = {
651653

652654
nClient.send(stanza);
653655
}
656+
657+
return paramsCreateMsg.id;
654658
},
655659
sendIsTypingStatus: function(jid_or_user_id) {
656660
var self = this,

src/qbConfig.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*/
1111

1212
var config = {
13-
version: '2.3.3',
13+
version: '2.3.4',
1414
creds: {
1515
appId: '',
1616
authKey: '',

0 commit comments

Comments
 (0)