Skip to content

Commit e70affa

Browse files
committed
refactor: removed useless thisArg from createFind
1 parent 7ebf935 commit e70affa

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/internal/operators/find.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,10 @@ export function find<T>(predicate: (value: T, index: number, source: Observable<
5151
* matches the condition.
5252
*/
5353
export function find<T>(predicate: (value: T, index: number, source: Observable<T>) => boolean): OperatorFunction<T, T | undefined> {
54-
return operate(createFind(predicate, undefined, 'value'));
54+
return operate(createFind(predicate, 'value'));
5555
}
5656

57-
export function createFind<T>(
58-
predicate: (value: T, index: number, source: Observable<T>) => boolean,
59-
thisArg: any,
60-
emit: 'value' | 'index'
61-
) {
57+
export function createFind<T>(predicate: (value: T, index: number, source: Observable<T>) => boolean, emit: 'value' | 'index') {
6258
const findIndex = emit === 'index';
6359
return (source: Observable<T>, subscriber: Subscriber<any>) => {
6460
let index = 0;
@@ -67,7 +63,7 @@ export function createFind<T>(
6763
subscriber,
6864
(value) => {
6965
const i = index++;
70-
if (predicate.call(thisArg, value, i, source)) {
66+
if (predicate(value, i, source)) {
7167
subscriber.next(findIndex ? i : value);
7268
subscriber.complete();
7369
}

src/internal/operators/findIndex.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,5 +48,5 @@ export function findIndex<T>(predicate: (value: T, index: number, source: Observ
4848
* first item that matches the condition.
4949
*/
5050
export function findIndex<T>(predicate: (value: T, index: number, source: Observable<T>) => boolean): OperatorFunction<T, number> {
51-
return operate(createFind(predicate, undefined, 'index'));
51+
return operate(createFind(predicate, 'index'));
5252
}

0 commit comments

Comments
 (0)