Skip to content
This repository was archived by the owner on Aug 25, 2019. It is now read-only.

Commit 50d2364

Browse files
committed
Don't make iomonitor so aggressive; just warn about scenario instead
1 parent 73bf893 commit 50d2364

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

BASIC-CONFIG.md

-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ docker run ... \
1717
...
1818
```
1919

20-
Note that the environment variable's value is equal to the linked container's name once converted to the variable format; that is a linked container name of `my.sql.container` would become `MY_SQL_CONTAINER`.
21-
2220
If your instance of MySQL is running on the host or some external system, you can connect to it using the `MYSQL_USER` and associated variables like so:
2321

2422
```

ENV-LIST.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
- `PHABRICATOR_HOST_KEYS_PATH` - The path to store SSH host keys in. This directory should be a volume mapped from the host, otherwise clients will be unable to connect after the container is restarted.
1212
- `AWS_S3_ACCESS_KEY` - The AWS access key to use for S3. Only needed when the `s3` storage type is selected.
1313
- `AWS_S3_SECRET_KEY` - The AWS secret key to use for S3. Only needed when the `s3` storage type is selected.
14-
- `MYSQL_LINKED_CONTAINER` - Use this if you want to connect to a MySQL container (see [Basic Configuration](BASIC-CONFIG.md)).
1514
- `MYSQL_HOST` - Use this if you want to connect to an external MySQL host (see [Basic Configuration](BASIC-CONFIG.md)).
1615
- `MYSQL_PORT` - When connecting to an external MySQL host, use this port (optional).
1716
- `MYSQL_USER` - The user to connect to MySQL as.
@@ -23,6 +22,7 @@
2322
- `SSL_CERTIFICATE` - The path to the SSL certificate chain (manual mode only).
2423
- `SSL_PRIVATE_KEY` - The path to the SSL private key (manual mode only).
2524
- `SSL_EMAIL` - The email address to use when registering for an SSL certificate (Let's Encrypt mode only)
25+
- `DISABLE_IOMONITOR` - Disable the I/O monitor, which warns if the image is spending a lot of CPU time waiting on disk I/O.
2626

2727
The following advanced options automatically turn on `ENABLE_UPDATE_ON_START`:
2828

iomonitor

+2-5
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
# Occasionally parsing Git diffs may consume all disk I/O
44
# on a server, impacting other services including the web
55
# front-end. This script monitors disk I/O and automatically
6-
# kills Git processes whenever the CPU has been waiting on
7-
# the disk for more than 50% of the CPU time in the last
8-
# 60 seconds.
6+
# warns the server administrator in the output log.
97

108
while [ 0 -eq 0 ]; do
119
RESULTS=$(top -b -n 2 -d 60 | awk '/[0-9.]\ wa,/{print $10}')
@@ -15,8 +13,7 @@ while [ 0 -eq 0 ]; do
1513
done
1614

1715
if echo $LAST_RESULT 50 | awk '{exit $1>$2?0:1}'; then
18-
echo "[iomonitor] Detected >50% CPU waiting on disk; automatically killing Git processes..."
19-
kill -KILL $(pidof git)
16+
echo "[iomonitor] Warning: detected >50% CPU waiting on disk. Consider increasing disk performance or using --cpu-quota to constrain Docker CPU usage."
2017
fi
2118

2219
sleep 2

0 commit comments

Comments
 (0)