[FIX] update CI validation (#503)

* update validation

* rm link

* comment failing part of CI for now

Author: Remi-Gau

.github/workflows/pythonpackage.yml

@@ -21,17 +21,19 @@ jobs:
       with:
         python-version: 3.12
     - name: Install dependencies
-      # TODO update to install from the latest version on reproschema
-      # once https://github.com/ReproNim/reproschema-py/pull/40 has been merged and a new release has been made.
+      # TODO This installs reproschema from source and not from pypi
+      # This may not be the optimal way of doing it.
       run: |
         python -m pip install --upgrade pip setuptools
-        pip install git+https://github.com/Remi-Gau/reproschema-py.git@skip
+        pip install git+https://github.com/ReproNim/reproschema-py.git
     - name: Test with pyshacl
       run: |
         python scripts/jsonParser.py
         reproschema validate examples
-    - name: Make a release
-      run: |
-        python scripts/makeRelease.py ci-release
-        pip install pytablewriter
-        python scripts/editProperties.py ci-release
+    # TODO adapt make release
+    # TODO use mkdocs macro to update doc content
+    # - name: Make a release
+    #   run: |
+    #     python scripts/makeRelease.py ci-release
+    #     pip install pytablewriter
+    #     python scripts/editProperties.py ci-release

docs/project-structure.md

@@ -31,7 +31,7 @@ The ReproSchema is like a blueprint for research projects, ensuring everyone col
     -   **Activity Level:** At this stage, an entire survey or tool, made up of many items, is grouped together as an "Activity." It gives a complete overview of what the survey involves.
     -   **Protocols Level:** The highest level, a "Protocol," bundles together all the activities a participant will do in a study, providing a comprehensive plan.
 
--   **[Validation](https://github.com/ReproNim/reproschema/tree/main/validation):** The schema uses special standards (like SHACL files) to make sure the data and forms are up to standard and consistent.
+-   **Validation:** The schema uses special standards (like SHACL files) to make sure the data and forms are up to standard and consistent.
 
 -   **Context Files:** These files ([`contexts`](https://github.com/ReproNim/reproschema/tree/master/contexts)and [`terms`](https://github.com/ReproNim/reproschema/tree/master/terms)) specify user-interface details and enhance schema flexibility. They define elements like input types, visibility conditions, and response options, supporting a tailored user experience. Additionally, they enable internationalization and multiple language support for broad applicability.
 

examples/activities/items/item2.jsonld

@@ -14,7 +14,6 @@
       "@type": "VideoObject",
       "contentUrl": "http://media.freesound.org/data/0/previews/719__elmomo__12oclock_girona_preview.mp4"
     },
-    "imageUrl": "http://example.com/sample-image.jpg",
     "ui": {
         "inputType": "float"
     },

scripts/jsonParser.py

@@ -7,6 +7,7 @@
     if os.path.basename(root) in schema_dirs:
         for name in files:
             with open(os.path.join(root, name)) as fp:
+                print(f" trying parsing {root}/{name} as json")
                 try:
                     tested += 1
                     json.load(fp)

scripts/makeRelease.py

@@ -10,7 +10,7 @@
 def create_release(version):
     # read all the terms
     terms = []
-    for root, dirs, files in os.walk("terms"):
+    for root, _, files in os.walk("terms"):
         for name in files:
             terms.extend(json.loads(to_newformat(os.path.join(root, name), "jsonld")))