Skip to content

Commit 4bd5f2d

Browse files
LegNeatoeddyb
authored andcommitted
rustup to nightly-2025-04-28
1 parent c78aae9 commit 4bd5f2d

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

crates/rustc_codegen_spirv/build.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ use std::{env, fs, mem};
1818
/// `cargo publish`. We need to figure out a way to do this properly, but let's hardcode it for now :/
1919
//const REQUIRED_RUST_TOOLCHAIN: &str = include_str!("../../rust-toolchain.toml");
2020
const REQUIRED_RUST_TOOLCHAIN: &str = r#"[toolchain]
21-
channel = "nightly-2025-04-27"
21+
channel = "nightly-2025-04-28"
2222
components = ["rust-src", "rustc-dev", "llvm-tools"]
23-
# commit_hash = 10fa3c449f6b1613b352a6cbf78d3d91fd9a1d81"#;
23+
# commit_hash = cb31a009e3e735ab08613cec2d8a5a754e65596f"#;
2424

2525
fn rustc_output(arg: &str) -> Result<String, Box<dyn Error>> {
2626
let rustc = env::var("RUSTC").unwrap_or_else(|_| "rustc".into());

crates/rustc_codegen_spirv/src/codegen_cx/declare.rs

+1-11
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ use rspirv::spirv::{FunctionControl, LinkageType, StorageClass, Word};
1212
use rustc_abi::Align;
1313
use rustc_attr_parsing::InlineAttr;
1414
use rustc_codegen_ssa::traits::{PreDefineCodegenMethods, StaticCodegenMethods};
15-
use rustc_hir::def::DefKind;
1615
use rustc_middle::bug;
1716
use rustc_middle::middle::codegen_fn_attrs::{CodegenFnAttrFlags, CodegenFnAttrs};
1817
use rustc_middle::mir::mono::{Linkage, MonoItem, Visibility};
@@ -133,16 +132,7 @@ impl<'tcx> CodegenCx<'tcx> {
133132

134133
let declared = fn_id.with_type(function_type);
135134

136-
let attrs = AggregatedSpirvAttributes::parse(
137-
self,
138-
match self.tcx.def_kind(def_id) {
139-
// This was made to ICE cross-crate at some point, but then got
140-
// reverted in https://github.com/rust-lang/rust/pull/111381.
141-
// FIXME(eddyb) remove this workaround once we rustup past that.
142-
DefKind::Closure => &[],
143-
_ => self.tcx.get_attrs_unchecked(def_id),
144-
},
145-
);
135+
let attrs = AggregatedSpirvAttributes::parse(self, self.tcx.get_attrs_unchecked(def_id));
146136
if let Some(entry) = attrs.entry.map(|attr| attr.value) {
147137
let entry_name = entry
148138
.name

rust-toolchain.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[toolchain]
2-
channel = "nightly-2025-04-27"
2+
channel = "nightly-2025-04-28"
33
components = ["rust-src", "rustc-dev", "llvm-tools"]
4-
# commit_hash = 10fa3c449f6b1613b352a6cbf78d3d91fd9a1d81
4+
# commit_hash = cb31a009e3e735ab08613cec2d8a5a754e65596f
55

66
# Whenever changing the nightly channel, update the commit hash above, and make
77
# sure to change `REQUIRED_TOOLCHAIN` in `crates/rustc_codegen_spirv/build.rs` also.

0 commit comments

Comments
 (0)