Skip to content

Commit 2db9621

Browse files
Ye Binaxboe
Ye Bin
authored andcommitted
blktrace: remove unnessary stop block trace in 'blk_trace_shutdown'
As previous commit, 'blk_trace_cleanup' will stop block trace if block trace's state is 'Blktrace_running'. So remove unnessary stop block trace in 'blk_trace_shutdown'. Signed-off-by: Ye Bin <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent dcd1a59 commit 2db9621

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

kernel/trace/blktrace.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -776,10 +776,8 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
776776
void blk_trace_shutdown(struct request_queue *q)
777777
{
778778
if (rcu_dereference_protected(q->blk_trace,
779-
lockdep_is_held(&q->debugfs_mutex))) {
780-
__blk_trace_startstop(q, 0);
779+
lockdep_is_held(&q->debugfs_mutex)))
781780
__blk_trace_remove(q);
782-
}
783781
}
784782

785783
#ifdef CONFIG_BLK_CGROUP

0 commit comments

Comments
 (0)