Skip to content

Commit d60a639

Browse files
committed
rust: introduce .clippy.toml
Some Clippy lints can be configured/tweaked. We will use these knobs to our advantage in later commits. This is done via a configuration file, `.clippy.toml` [1]. The file is currently unstable. This may be a problem in the future, but we can adapt as needed. In addition, we proposed adding Clippy to the Rust CI's RFL job [2], so we should be able to catch issues pre-merge. Thus introduce the file. Link: https://doc.rust-lang.org/clippy/configuration.html [1] Link: rust-lang/rust#128928 [2] Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Tested-by: Gary Guo <[email protected]> Reviewed-by: Gary Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
1 parent 7a06c75 commit d60a639

File tree

4 files changed

+6
-0
lines changed

4 files changed

+6
-0
lines changed

.clippy.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# SPDX-License-Identifier: GPL-2.0

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ modules.order
103103
# We don't want to ignore the following even if they are dot-files
104104
#
105105
!.clang-format
106+
!.clippy.toml
106107
!.cocciconfig
107108
!.editorconfig
108109
!.get_maintainer.ignore

MAINTAINERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20222,6 +20222,7 @@ B: https://github.com/Rust-for-Linux/linux/issues
2022220222
C: zulip://rust-for-linux.zulipchat.com
2022320223
P: https://rust-for-linux.com/contributing
2022420224
T: git https://github.com/Rust-for-Linux/linux.git rust-next
20225+
F: .clippy.toml
2022520226
F: Documentation/rust/
2022620227
F: rust/
2022720228
F: samples/rust/

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,9 @@ endif
587587
# Allows the usage of unstable features in stable compilers.
588588
export RUSTC_BOOTSTRAP := 1
589589

590+
# Allows finding `.clippy.toml` in out-of-srctree builds.
591+
export CLIPPY_CONF_DIR := $(srctree)
592+
590593
export ARCH SRCARCH CONFIG_SHELL BASH HOSTCC KBUILD_HOSTCFLAGS CROSS_COMPILE LD CC HOSTPKG_CONFIG
591594
export RUSTC RUSTDOC RUSTFMT RUSTC_OR_CLIPPY_QUIET RUSTC_OR_CLIPPY BINDGEN
592595
export HOSTRUSTC KBUILD_HOSTRUSTFLAGS

0 commit comments

Comments
 (0)