Fix the tests

Author: roblabla

Cargo.toml

@@ -21,9 +21,7 @@ rand = "0.6.5"
 byteorder = "1.3.1"
 failure = "0.1.5"
 subtle = "2.0.0"
-signature = { version = "0.2.0" }
-sha2 = { version = "0.8" }
-sha-1 = { version = "0.8.1" }
+digest = "0.8"
 
 [dependencies.zeroize]
 version = "0.6"
@@ -39,6 +37,7 @@ features = ["std", "derive"]
 base64 = "0.10.1"
 hex = "0.3.2"
 serde_test = "1.0.89"
+sha-1 = "0.8.1"
 
 
 [[bench]]

src/key.rs

@@ -390,8 +390,10 @@ mod tests {
     #[test]
     fn test_from_into() {
         let private_key = RSAPrivateKey {
-            n: BigUint::from_u64(100).unwrap(),
-            e: BigUint::from_u64(200).unwrap(),
+            pubkey_components: RSAPublicKey {
+                n: BigUint::from_u64(100).unwrap(),
+                e: BigUint::from_u64(200).unwrap(),
+            },
             d: BigUint::from_u64(123).unwrap(),
             primes: vec![],
             precomputed: None,

src/lib.rs

@@ -8,7 +8,7 @@
 //! extern crate rsa;
 //! extern crate rand;
 //!
-//! use rsa::{PublicKey, RSAPrivateKey, PaddingScheme};
+//! use rsa::RSAPrivateKey;
 //! use rand::rngs::OsRng;
 //!
 //! let mut rng = OsRng::new().expect("no secure randomness available");
@@ -17,11 +17,11 @@
 //!
 //! // Encrypt
 //! let data = b"hello world";
-//! let enc_data = key.encrypt(&mut rng, PaddingScheme::PKCS1v15, &data[..]).expect("failed to encrypt");
+//! let enc_data = key.encrypt_pkcs1v15(&mut rng, &data[..]).expect("failed to encrypt");
 //! assert_ne!(&data[..], &enc_data[..]);
 //!
 //! // Decrypt
-//! let dec_data = key.decrypt(PaddingScheme::PKCS1v15, &enc_data).expect("failed to decrypt");
+//! let dec_data = key.decrypt_pkcs1v15(&enc_data).expect("failed to decrypt");
 //! assert_eq!(&data[..], &dec_data[..]);
 //! ```
 //!
@@ -57,15 +57,11 @@ pub mod errors;
 /// Supported hash functions.
 pub mod hash;
 
-/// Supported padding schemes.
-pub mod padding;
-
 mod key;
 mod pkcs1v15;
 mod pss;
 
 pub use self::key::{RSAPrivateKey, RSAPublicKey};
-pub use self::padding::PaddingScheme;
 
 // Optionally expose internals if requested via feature-flag.
 

src/padding.rs

@@ -266,7 +266,6 @@ mod tests {
 
     use crate::hash::Hashes;
     use crate::key::RSAPublicKey;
-    use crate::padding::PaddingScheme;
 
     #[test]
     fn test_non_zero_bytes() {
@@ -323,7 +322,7 @@ mod tests {
 
         for test in &tests {
             let out = priv_key
-                .decrypt(PaddingScheme::PKCS1v15, &base64::decode(test[0]).unwrap())
+                .decrypt_pkcs1v15(&base64::decode(test[0]).unwrap())
                 .unwrap();
             assert_eq!(out, test[1].as_bytes());
         }
@@ -364,16 +363,15 @@ mod tests {
             let expected = hex::decode(test[1]).unwrap();
 
             let out = priv_key
-                .sign(PaddingScheme::PKCS1v15, Some(&Hashes::SHA1), &digest)
+                .sign_pkcs1v15(Some(&Hashes::SHA1), &digest)
                 .unwrap();
             assert_ne!(out, digest);
             assert_eq!(out, expected);
 
             let mut rng = thread_rng();
             let out2 = priv_key
-                .sign_blinded(
+                .sign_pkcs1v15_blinded(
                     &mut rng,
-                    PaddingScheme::PKCS1v15,
                     Some(&Hashes::SHA1),
                     &digest,
                 )
@@ -396,7 +394,7 @@ mod tests {
             let sig = hex::decode(test[1]).unwrap();
 
             pub_key
-                .verify(PaddingScheme::PKCS1v15, Some(&Hashes::SHA1), &digest, &sig)
+                .verify_pkcs1v15(Some(&Hashes::SHA1), &digest, &sig)
                 .expect("failed to verify");
         }
     }
@@ -408,13 +406,13 @@ mod tests {
         let priv_key = get_private_key();
 
         let sig = priv_key
-            .sign::<Hashes>(PaddingScheme::PKCS1v15, None, msg)
+            .sign_pkcs1v15::<Hashes>(None, msg)
             .unwrap();
         assert_eq!(expected_sig, sig);
 
         let pub_key: RSAPublicKey = priv_key.into();
         pub_key
-            .verify(PaddingScheme::PKCS1v15, None, msg, &sig)
+            .verify_pkcs1v15::<Hashes>(None, msg, &sig)
             .expect("failed to verify");
     }
 }