Skip to content

aead: do not enable alloc by default? #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
newpavlov opened this issue Aug 26, 2020 · 2 comments
Closed

aead: do not enable alloc by default? #273

newpavlov opened this issue Aug 26, 2020 · 2 comments
Labels
aead Authenticated Encryption with Associated Data (AEAD) crate

Comments

@newpavlov
Copy link
Member

newpavlov commented Aug 26, 2020 •
edited
Loading

Right now only aead enables alloc by default, which forces implementation crates to use default-features = false. Removing a default feature is a breaking change, so it would have to be done in v0.4.
@newpavlov newpavlov added the aead Authenticated Encryption with Associated Data (AEAD) crate label Aug 26, 2020
@tarcieri
Copy link
Member

This seems like an artifact of when alloc was mandatory. I'd agree with disabling it per default.

(as it were, signature enables std by default as well, although fixing this is tracked in #237)

@tarcieri
Copy link
Member

One important change we'd have to do along with this is very clearly document enabling the alloc feature to use the allocating APIs, which are prominently featured in each crate.

@tarcieri tarcieri mentioned this issue Jan 3, 2021
Merged
tarcieri added a commit that referenced this issue Jan 31, 2021
@tarcieri
aead: disable alloc by default (closes #273)
62b626f 
The `alloc` feature used to be a mandatory part of the `aead` API, but
in the time since we've introduced in-place traits that allow for fully
heapless usage.

This commit removes it as a default feature.
dns2utf8 pushed a commit to dns2utf8/traits that referenced this issue Jan 24, 2023
@newpavlov
Test and fix min versions build (RustCrypto#273)
70063ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aead Authenticated Encryption with Associated Data (AEAD) crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @newpavlov