Build parser without lalrpop binary

Author: moreal

parser/Cargo.toml

@@ -11,7 +11,7 @@ edition = "2021"
 [build-dependencies]
 tiny-keccak = { version = "2", features = ["sha3"] }
 phf_codegen = "0.10"
-lalrpop = { version = "0.19.8", optional = true }
+lalrpop = { version = "0.19.8" }
 anyhow = "1.0.45"
 
 [dependencies]

parser/build.rs

@@ -70,36 +70,12 @@ fn try_lalrpop(source: &str, target: &str) -> anyhow::Result<()> {
         return Ok(());
     }
 
-    #[cfg(feature = "lalrpop")]
-    lalrpop_dependency();
-    #[cfg(not(feature = "lalrpop"))]
-    lalrpop_command(source)?;
+    lalrpop();
 
     Ok(())
 }
 
-#[cfg(not(feature = "lalrpop"))]
-fn lalrpop_command(source: &str) -> anyhow::Result<()> {
-    match std::process::Command::new("lalrpop").arg(source).status() {
-        Ok(stat) if stat.success() => Ok(()),
-        Ok(stat) => {
-            eprintln!("failed to execute lalrpop; exited with {stat}");
-            let exit_code = stat.code().map(|v| (v % 256) as u8).unwrap_or(1);
-            Err(anyhow::anyhow!("lalrpop error status: {}", exit_code))
-        }
-        Err(e) if e.kind() == std::io::ErrorKind::NotFound => {
-            eprintln!("please install lalrpop with `cargo install lalrpop` or\n`cargo build --manifest-path=parser/Cargo.toml --features=lalrpop`");
-            Err(anyhow::anyhow!(
-                "the lalrpop executable is not installed and parser/{} has been changed",
-                source
-            ))
-        }
-        Err(e) => Err(anyhow::Error::new(e)),
-    }
-}
-
-#[cfg(feature = "lalrpop")]
-fn lalrpop_dependency() {
+fn lalrpop() {
     lalrpop::process_root().unwrap()
 }